[source-mongo] : Adopt CDK 0.28.0 #36837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
rodireich
reviewed
Apr 4, 2024
| @@ -0,0 +1 @@ | |||
| JunitMethodExecutionTimeout=2 m | |||
There was a problem hiding this comment.
something was failing with default I guess?
There was a problem hiding this comment.
Yeah the default of 1m wasn't enough. See the notes in the PR description for when the regression was introduced. TLDR at some point the defaults went from 5m -> 1m in the cdk w/out testing on other connectors
rodireich
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings source-mongo to version 0.28.0 (last Java version) and fixes some test regressions :
0.23.13, PR : minor changes to the java CDK test code #35774:DefaultAirbyteSourceno longer throws aTestHarnessException, so we can actually check for error trace messages in the integration test.0.23.15, PR : java-CDK fixes to the Junit interceptor #35827Default timeout for all tests was reduced from 5m -> 1m. This PR increases it to 2m since tests are timing out
0.23.20, PR : configure debezium to correctly convert column with default value whe… #36011New CDC property was introduced, fixing tests to reflect this