Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [source-bing-ads] add missing fields for keyword_performance_report #35878

Closed
wants to merge 3 commits into from
Closed

✨ [source-bing-ads] add missing fields for keyword_performance_report #35878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3df9ce7
add new fields for keyword_performance_report
KimPlv Mar 7, 2024
381309b
update version
KimPlv Mar 7, 2024
4ac5c64
update unit tests
KimPlv Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-bing-ads/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 47f25999-dd5e-4636-8c39-e7cea2453331
dockerImageTag: 2.4.0
dockerImageTag: 2.4.1
dockerRepository: airbyte/source-bing-ads
documentationUrl: https://docs.airbyte.com/integrations/sources/bing-ads
githubIssueLabel: source-bing-ads
Expand Down
48 changes: 48 additions & 0 deletions ...ations/connectors/source-bing-ads/source_bing_ads/schemas/keyword_performance_report.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,54 @@
},
"RevenuePerAssist": {
"type": ["null", "number"]
},
"CampaignStatus": {
"type": ["null", "string"]
},
"TopImpressionRatePercent": {
"type": ["null", "string"]
},
"AdGroupStatus": {
"type": ["null", "string"]
},
"TrackingTemplate": {
"type": ["null", "string"]
},
"BidStrategyType": {
"type": ["null", "string"]
},
"AccountStatus": {
"type": ["null", "string"]
},
"FinalUrl": {
"type": ["null", "string"]
},
"AdType": {
"type": ["null", "string"]
},
"KeywordLabels": {
"type": ["null", "string"]
},
"FinalMobileUrl": {
"type": ["null", "string"]
},
"Goal": {
"type": ["null", "string"]
},
"GoalType": {
"type": ["null", "string"]
},
"AbsoluteTopImpressionRatePercent": {
"type": ["null", "string"]
},
"BaseCampaignId": {
"type": ["null", "string"]
},
"AccountNumber": {
"type": ["null", "string"]
},
"DestinationUrl": {
"type": ["null", "string"]
}
}
}
48 changes: 48 additions & 0 deletions .../connectors/source-bing-ads/source_bing_ads/schemas/keyword_performance_report_daily.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,54 @@
},
"RevenuePerAssist": {
"type": ["null", "number"]
},
"CampaignStatus": {
"type": ["null", "string"]
},
"TopImpressionRatePercent": {
"type": ["null", "string"]
},
"AdGroupStatus": {
"type": ["null", "string"]
},
"TrackingTemplate": {
"type": ["null", "string"]
},
"BidStrategyType": {
"type": ["null", "string"]
},
"AccountStatus": {
"type": ["null", "string"]
},
"FinalUrl": {
"type": ["null", "string"]
},
"AdType": {
"type": ["null", "string"]
},
"KeywordLabels": {
"type": ["null", "string"]
},
"FinalMobileUrl": {
"type": ["null", "string"]
},
"Goal": {
"type": ["null", "string"]
},
"GoalType": {
"type": ["null", "string"]
},
"AbsoluteTopImpressionRatePercent": {
"type": ["null", "string"]
},
"BaseCampaignId": {
"type": ["null", "string"]
},
"AccountNumber": {
"type": ["null", "string"]
},
"DestinationUrl": {
"type": ["null", "string"]
}
}
}
48 changes: 48 additions & 0 deletions ...connectors/source-bing-ads/source_bing_ads/schemas/keyword_performance_report_hourly.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,54 @@
},
"RevenuePerAssist": {
"type": ["null", "number"]
},
"CampaignStatus": {
"type": ["null", "string"]
},
"TopImpressionRatePercent": {
"type": ["null", "string"]
},
"AdGroupStatus": {
"type": ["null", "string"]
},
"TrackingTemplate": {
"type": ["null", "string"]
},
"BidStrategyType": {
"type": ["null", "string"]
},
"AccountStatus": {
"type": ["null", "string"]
},
"FinalUrl": {
"type": ["null", "string"]
},
"AdType": {
"type": ["null", "string"]
},
"KeywordLabels": {
"type": ["null", "string"]
},
"FinalMobileUrl": {
"type": ["null", "string"]
},
"Goal": {
"type": ["null", "string"]
},
"GoalType": {
"type": ["null", "string"]
},
"AbsoluteTopImpressionRatePercent": {
"type": ["null", "string"]
},
"BaseCampaignId": {
"type": ["null", "string"]
},
"AccountNumber": {
"type": ["null", "string"]
},
"DestinationUrl": {
"type": ["null", "string"]
}
}
}
5 changes: 3 additions & 2 deletions ...integrations/connectors/source-bing-ads/unit_tests/hourly_reports/keyword_performance.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
AccountId,CampaignId,AdGroupId,KeywordId,Keyword,AdId,TimePeriod,CurrencyCode,DeliveredMatchType,AdDistribution,DeviceType,Language,Network,DeviceOS,TopVsOther,BidMatchType,AccountName,CampaignName,AdGroupName,KeywordStatus,Impressions,Clicks,Ctr,CurrentMaxCpc,Spend,CostPerConversion,QualityScore,ExpectedCtr,AdRelevance,LandingPageExperience,QualityImpact,Assists,ReturnOnAdSpend,CostPerAssist,CustomParameters,FinalAppUrl,Mainline1Bid,MainlineBid,FirstPageBid,FinalUrlSuffix,ViewThroughConversions,ViewThroughConversionsQualified,AllCostPerConversion,AllReturnOnAdSpend,Conversions,ConversionRate,ConversionsQualified,AverageCpc,AveragePosition,AverageCpm,AllConversions,AllConversionRate,AllRevenue,AllRevenuePerConversion,Revenue,RevenuePerConversion,RevenuePerAssist
180519267,531016227,1356799861840328,84801135055365,connector,84800390693061,2023-11-10T00:00:00+00:00,USD,Phrase,Search,Smartphone,German,Syndicated search partners,Android,Syndicated search partners - Top,Broad,Airbyte,Airbyte test,keywords,Active,1,0,0,2.27,0,,5,2,3,1,0,0,,,,,,1.11,0.35,,0,,,,0,,0,0,0,0,0,,0,,0,,
AccountId,CampaignId,AdGroupId,KeywordId,Keyword,AdId,TimePeriod,CurrencyCode,DeliveredMatchType,AdDistribution,DeviceType,Language,Network,DeviceOS,TopVsOther,BidMatchType,AccountName,CampaignName,AdGroupName,KeywordStatus,Impressions,Clicks,Ctr,CurrentMaxCpc,Spend,CostPerConversion,QualityScore,ExpectedCtr,AdRelevance,LandingPageExperience,QualityImpact,Assists,ReturnOnAdSpend,CostPerAssist,CustomParameters,FinalAppUrl,Mainline1Bid,MainlineBid,FirstPageBid,FinalUrlSuffix,ViewThroughConversions,ViewThroughConversionsQualified,AllCostPerConversion,AllReturnOnAdSpend,Conversions,ConversionRate,ConversionsQualified,AverageCpc,AveragePosition,AverageCpm,AllConversions,AllConversionRate,AllRevenue,AllRevenuePerConversion,Revenue,RevenuePerConversion,RevenuePerAssist,CampaignStatus,TopImpressionRatePercent,AdGroupStatus,TrackingTemplate,BidStrategyType,AccountStatus,FinalUrl,AdType,KeywordLabels,FinalMobileUrl,Goal,GoalType,AbsoluteTopImpressionRatePercent,BaseCampaignId,AccountNumber,DestinationUrl
180519267,531016227,1356799861840328,84801135055365,connector,84800390693061,2023-11-10T00:00:00+00:00,USD,Phrase,Search,Smartphone,German,Syndicated search partners,Android,Syndicated search partners - Top,Broad,Airbyte,Airbyte test,keywords,Active,1,0,0,2.27,0,,5,2,3,1,0,0,,,,,,1.11,0.35,,0,,,,0,,0,0,0,0,0,,0,,0,,,Active,,Active,,Enhanced CPC,Active,https://landing.hello.com/en/email-marketing-service/,Responsive ad,Email_Marketing,,,,,278665388,B0149SGJ,

20 changes: 18 additions & 2 deletions ...ons/connectors/source-bing-ads/unit_tests/hourly_reports/keyword_performance_records.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,22 @@
"TimePeriod": "2023-11-10T00:00:00+00:00",
"TopVsOther": "Syndicated search partners - Top",
"ViewThroughConversions": "0",
"ViewThroughConversionsQualified": null
"ViewThroughConversionsQualified": null,
"CampaignStatus": "Active",
"TopImpressionRatePercent": null,
"AdGroupStatus": "Active",
"TrackingTemplate": null,
"BidStrategyType": "Enhanced CPC",
"AccountStatus": "Active",
"FinalUrl": "https://landing.hello.com/en/email-marketing-service/",
"AdType": "Responsive ad",
"KeywordLabels": "Email_Marketing",
"FinalMobileUrl": null,
"Goal": null,
"GoalType": null,
"AbsoluteTopImpressionRatePercent": null,
"BaseCampaignId": "278665388",
"AccountNumber": "B0149SGJ",
"DestinationUrl": null
}
]
]
1 change: 1 addition & 0 deletions docs/integrations/sources/bing-ads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ The Bing Ads API limits the number of requests for all Microsoft Advertising cli

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------------------------------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------------------------------------|
| 2.4.1 | 2024-03-25 | [35878](https://github.com/airbytehq/airbyte/pull/35878) | Add missing fields in keyword_performance_report |
| 2.4.0 | 2024-03-19 | [36267](https://github.com/airbytehq/airbyte/pull/36267) | Pin airbyte-cdk version to `^0` |
| 2.3.0 | 2024-03-05 | [35812](https://github.com/airbytehq/airbyte/pull/35812) | New streams: Audience Performance Report, Goals And Funnels Report, Product Dimension Performance Report. |
| 2.2.0 | 2024-02-13 | [35201](https://github.com/airbytehq/airbyte/pull/35201) | New streams: Budget and Product Dimension Performance. |
Expand Down