Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [source-bing-ads] add missing fields for keyword_performance_report #35878

Closed

Conversation

KimPlv
Copy link
Contributor

@KimPlv KimPlv commented Mar 7, 2024

Issue 35877

What

Add new fields for keyword_performance_report

  • CampaignStatus
  • TopImpressionRatePercent
  • AdGroupStatus
  • TrackingTemplate
  • BidStrategyType
  • AccountStatus
  • FinalUrl
  • AdType
  • KeywordLabels
  • FinalMobileUrl
  • Goal
  • GoalType
  • AbsoluteTopImpressionRatePercent
  • BaseCampaignId
  • AccountNumber
  • DestinationUrl

Recommended reading order

  1. y.python

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Connector version is set to 2.2.1
  • Documentation updated
    • docs/integrations/source/bing-ads.md including changelog with an entry for the initial version.
    • docs/integrations/README.md

Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 1:19pm

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2024

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/bing-ads labels Mar 7, 2024
@KimPlv KimPlv force-pushed the airbyte/update_source_bing_ads branch from ffb1948 to 554f690 Compare March 7, 2024 13:33
@octavia-squidington-iii octavia-squidington-iii added area/documentation Improvements or additions to documentation and removed area/documentation Improvements or additions to documentation labels Mar 7, 2024
@marcosmarxm
Copy link
Member

@KimPlv need you to sign the CLA to continue the review process.

@marcosmarxm marcosmarxm reopened this Mar 14, 2024
@marcosmarxm
Copy link
Member

@KimPlv need all contributors to all commits sign the CLA. Waiting to make the first review.

@marcosmarxm marcosmarxm changed the title ✨ Source Bing Ads : add missing fields for keyword_performance_report ✨ [source-bing-ads] add missing fields for keyword_performance_report Mar 19, 2024
@marcosmarxm marcosmarxm changed the title ✨ [source-bing-ads] add missing fields for keyword_performance_report ✨ [source-bing-ads] add missing fields for keyword_performance_report Mar 19, 2024
@artem1205
Copy link
Collaborator

@KimPlv, thanks for raised PR,
closed in #37545

@artem1205 artem1205 closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants