Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Intercom: handle conversations stream HttpError: 404 - User Not Found #36277

Merged
merged 9 commits into from Mar 22, 2024
Merged

🐛 Source Intercom: handle conversations stream HttpError: 404 - User Not Found #36277

merged 9 commits into from Mar 22, 2024

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Mar 19, 2024 •
edited

What

Resolving:

How

  • downgraded the conversations stream to use the 2.9 API version, instead of the 2.10, where the 404 - User Not Found bug occurs for some Customers, that have the external users attached to their conversations.

There are no diffs between 2.9 and 2.10 in terms of the schema, so we're safe to do this change.

@bazarnov bazarnov self-assigned this Mar 19, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 19, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 8:26pm

@bazarnov
Copy link
Collaborator Author

The pre-release version of the source-intercom has been published. The tag: 0.6.2-dev.bbd49c0fc2

@bazarnov
Copy link
Collaborator Author

The pre-release version of the source-intercom has been published. The tag: 0.6.2-dev.dc00d8a8a6, this one is based on the Intercom-Version: 2.9 instead of the 2.10, which appears to have bugs with the search method for the conversations endpoint.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 22, 2024
@bazarnov bazarnov marked this pull request as ready for review March 22, 2024 11:07
@octavia-squidington-iv octavia-squidington-iv requested review from a team March 22, 2024 11:09
@bazarnov bazarnov changed the title 🐛 Source Intercom: Handle 404 User Not Found 🐛 Source Intercom: handle conversations stream HttpError: 404 - User Not Found Mar 22, 2024
@bazarnov bazarnov force-pushed the baz/source/intercom/fix-404 branch from c67bd46 to 95df57f Compare March 22, 2024 20:37
@bazarnov
Copy link
Collaborator Author

There are some non-related formatting issues observed, will wait until these are fixed.

https://github.com/airbytehq/airbyte/actions/runs/8396167842/job/22996972694?pr=36277

@bazarnov bazarnov enabled auto-merge (squash) March 22, 2024 20:52
@bazarnov bazarnov disabled auto-merge March 22, 2024 20:52
@bazarnov bazarnov merged commit f11f1cb into master Mar 22, 2024
50 of 52 checks passed
@bazarnov bazarnov deleted the baz/source/intercom/fix-404 branch March 22, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askarpets askarpets askarpets approved these changes

@darynaishchenko darynaishchenko darynaishchenko approved these changes

Assignees

@bazarnov bazarnov

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/duckdb connectors/source/intercom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bazarnov @askarpets @darynaishchenko @octavia-squidington-iii