Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination snoiwflake: fix state handling with QUOTED_IDENTIFIERS_IGNORE_CASE=TRUE #36396

Merged
merged 8 commits into from Mar 25, 2024

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Mar 22, 2024

closes https://github.com/airbytehq/oncall/issues/4531

when a user forces identifiers into uppercase, our code currently fails to find the state data (b/c jsonnodes are case-sensitive). Do a hacky thing to just forcibly downcase everything.

@edgao edgao requested a review from a team as a code owner March 22, 2024 17:40
Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 6:33pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/destination/snowflake labels Mar 22, 2024
Copy link
Contributor

@gisripa gisripa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@edgao edgao merged commit a8fa18f into master Mar 25, 2024
33 checks passed
@edgao edgao deleted the edgao/snowflake_state_case_sensitivity branch March 25, 2024 19:36
stephane-airbyte added a commit that referenced this pull request Mar 25, 2024
stephane-airbyte added a commit that referenced this pull request Mar 25, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 26, 2024
stephane-airbyte added a commit that referenced this pull request Mar 27, 2024
stephane-airbyte added a commit that referenced this pull request Mar 27, 2024
stephane-airbyte added a commit that referenced this pull request Mar 27, 2024
stephane-airbyte added a commit that referenced this pull request Mar 27, 2024
stephane-airbyte added a commit that referenced this pull request Mar 27, 2024
stephane-airbyte added a commit that referenced this pull request Mar 27, 2024
stephane-airbyte added a commit that referenced this pull request Mar 27, 2024
stephane-airbyte added a commit that referenced this pull request Mar 27, 2024
stephane-airbyte added a commit that referenced this pull request Mar 27, 2024
nurikk pushed a commit to nurikk/airbyte that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/snowflake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants