New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination snoiwflake: fix state handling with QUOTED_IDENTIFIERS_IGNORE_CASE=TRUE #36396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Connector related issues
CDK
Connector Development Kit
connectors/destination/snowflake
labels
Mar 22, 2024
jbfbell
approved these changes
Mar 22, 2024
gisripa
approved these changes
Mar 22, 2024
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
Mar 25, 2024
gisripa
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stephane-airbyte
added a commit
that referenced
this pull request
Mar 25, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 25, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 26, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 27, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 27, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 27, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 27, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 27, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 27, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 27, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 27, 2024
stephane-airbyte
added a commit
that referenced
this pull request
Mar 27, 2024
nurikk
pushed a commit
to nurikk/airbyte
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
CDK
Connector Development Kit
connectors/destination/snowflake
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/airbytehq/oncall/issues/4531
when a user forces identifiers into uppercase, our code currently fails to find the state data (b/c jsonnodes are case-sensitive). Do a hacky thing to just forcibly downcase everything.