Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination snowflake: Depend on published cdk artifact #36461

Merged
merged 10 commits into from Mar 26, 2024
Merged

Destination snowflake: Depend on published cdk artifact #36461

merged 10 commits into from Mar 26, 2024

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Mar 25, 2024

code changes in #36396; forgot to publish cdk >.>

@vercel Vercel
Copy link

vercel bot commented Mar 25, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 4:28pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Mar 25, 2024
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Mar 25, 2024
@edgao edgao marked this pull request as ready for review March 25, 2024 20:07
@edgao edgao requested review from a team as code owners March 25, 2024 20:07
@edgao
Copy link
Contributor Author

edgao commented Mar 25, 2024 •
edited by github-actions bot

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/8427241390
✅ Successfully published Java CDK version=0.27.2!

@edgao edgao enabled auto-merge (squash) March 25, 2024 21:43
@edgao edgao requested a review from a team as a code owner March 26, 2024 10:32
@alafanechere
Copy link
Contributor

@edgao I ran the test on a pre-release version of airbyte-ci which is likely fixing the problem you had in using the latest CDK . The airbyte-ci PR is here: #36480

alafanechere and others added 2 commits March 26, 2024 11:50
@alafanechere
Revert "TO REVERT: use airbyte-ci pre-release"
bb2f219 
This reverts commit e8ba2a0.
@edgao
Merge branch 'master' into edgao/cdk_publish
8f7f9e9 
# Conflicts:
#	airbyte-cdk/java/airbyte-cdk/README.md
#	airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties
@edgao
Copy link
Contributor Author

edgao commented Mar 26, 2024 •
edited by github-actions bot

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/8438453508
✅ Successfully published Java CDK version=0.27.5!

@edgao edgao enabled auto-merge (squash) March 26, 2024 16:19
@edgao edgao merged commit 5bb8050 into master Mar 26, 2024
29 checks passed
@edgao edgao deleted the edgao/cdk_publish branch March 26, 2024 16:35
nurikk pushed a commit to nurikk/airbyte that referenced this pull request Apr 4, 2024
@edgao @alafanechere @nurikk-sa
Destination snowflake: Depend on published cdk artifact (airbytehq#36461
15870df 
)

Co-authored-by: alafanechere <augustin.lafanechere@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbfbell jbfbell jbfbell approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@edgao @alafanechere @jbfbell @octavia-squidington-iii