Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAT: migrate to CDK #3640

Merged
merged 2 commits into from
May 28, 2021
Merged

SAT: migrate to CDK #3640

merged 2 commits into from
May 28, 2021

Conversation

keu
Copy link
Contributor

@keu keu commented May 26, 2021

What

Don't use base python docker-based build.

How

Describe the solution

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

@keu keu requested review from sherifnada and removed request for masonwheeler and davinchia May 26, 2021 18:31
sherifnada
sherifnada reviewed May 26, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any imports needed to change?

@keu
Copy link
Contributor Author

keu commented May 26, 2021

Are there any imports needed to change?

@sherifnada nope, it was already using CDK

@keu
Copy link
Contributor Author

keu commented May 26, 2021 •
edited by github-actions bot
Loading

/publish connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/879669270
❌ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/879669270

@keu
Copy link
Contributor Author

keu commented May 26, 2021 •
edited by github-actions bot
Loading

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/879690996
❌ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/879690996
🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/879690996
❌ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/879690996

@keu
Copy link
Contributor Author

keu commented May 26, 2021 •
edited by github-actions bot
Loading

/test connector=source-klaviyo

🕑 source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/879739375
✅ source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/879739375

@keu
Copy link
Contributor Author

keu commented May 28, 2021 •
edited by github-actions bot
Loading

/publish connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/884691224
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/884691224

@keu keu merged commit c61fc3d into master May 28, 2021
@keu keu deleted the keu/sat-migrate-to-cdk branch May 28, 2021 08:32
@brianjlai brianjlai mentioned this pull request May 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

Assignees
No one assigned
Labels
connectors/source/facebook-marketing connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@keu @sherifnada @karinakuz @eugene-kulak