🐛 Source Intercom: Fixed regression for the conversations stream
#36414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
|
@girarda Can I ask you to check why this is happening : https://github.com/airbytehq/airbyte/actions/runs/8400165175/job/23007124901?pr=36414#step:5:281 ? Since yesterday, actually, but the master commits are green, which is confusing. |
bazarnov
deleted the
baz/source/intercom/fix-pagination-conversations-stream
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolving:
What happened
The
manifestlooked at the wrong$ref, pointing the Incrementalconversationsstream to thefull-refreshretriever, which caused thepaginationregression making thenext_page_tokento be the part of theurl_path, rather than therequest_body_jsonpart, as it should be.Switching the
$refsresolves the issue.