Source Chargebee - Unpin CDK & Update Semi-Incremental Component #36518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of empty dict
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
brianjlai
reviewed
Mar 28, 2024
There was a problem hiding this comment.
I do have one question about what caused the change to test behavior across all the tests so that we now actually need to check for timestamp - 1 now.
Another small nit is a lot of these files are missing the newline character at the end of the files. Can we clean that up a little bit then can approve
airbyte-integrations/connectors/source-chargebee/unit_tests/integration/test_addon.py
Show resolved
Hide resolved
askarpets
suggested changes
Apr 4, 2024
airbyte-integrations/connectors/source-chargebee/unit_tests/integration/test_addon.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-chargebee/unit_tests/integration/test_customer.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-chargebee/unit_tests/integration/test_event.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-chargebee/unit_tests/integration/test_hosted_page.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-chargebee/unit_tests/integration/test_plan.py
Outdated
Show resolved
Hide resolved
...ntegrations/connectors/source-chargebee/unit_tests/integration/test_site_migration_detail.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-chargebee/unit_tests/integration/test_subscription.py
Outdated
Show resolved
Hide resolved
...integrations/connectors/source-chargebee/unit_tests/integration/test_virtual_bank_account.py
Outdated
Show resolved
Hide resolved
askarpets
reviewed
Apr 10, 2024
| ({"pk": 1, "name": "example", "updated_at": 1662459011}, True), | ||
| ] | ||
| ) | ||
| def test_slicer(record_data, expected): |
There was a problem hiding this comment.
Why do we need to parametrize this test? There's only one input set
askarpets
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What