-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Chargebee - Unpin CDK & Update Semi-Incremental Component #36518
Conversation
… instead of empty dict
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do have one question about what caused the change to test behavior across all the tests so that we now actually need to check for timestamp - 1 now.
Another small nit is a lot of these files are missing the newline character at the end of the files. Can we clean that up a little bit then can approve
airbyte-integrations/connectors/source-chargebee/unit_tests/integration/test_addon.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-chargebee/unit_tests/integration/test_addon.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-chargebee/unit_tests/integration/test_customer.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-chargebee/unit_tests/integration/test_event.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-chargebee/unit_tests/integration/test_hosted_page.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-chargebee/unit_tests/integration/test_plan.py
Outdated
Show resolved
Hide resolved
...ntegrations/connectors/source-chargebee/unit_tests/integration/test_site_migration_detail.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-chargebee/unit_tests/integration/test_subscription.py
Outdated
Show resolved
Hide resolved
...integrations/connectors/source-chargebee/unit_tests/integration/test_virtual_bank_account.py
Outdated
Show resolved
Hide resolved
({"pk": 1, "name": "example", "updated_at": 1662459011}, True), | ||
] | ||
) | ||
def test_slicer(record_data, expected): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to parametrize this test? There's only one input set
What