Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabling spotbugs for datastore-postgres submodule #36704

Conversation

stephane-airbyte
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2024 9:40pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Mar 29, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_spotbugs_for_gcs-destinations_submodule branch from 5ea1369 to 5bd0fe9 Compare April 1, 2024 15:19
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule branch from 1c4ccac to 8c92b70 Compare April 1, 2024 15:19
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_spotbugs_for_gcs-destinations_submodule branch from 5bd0fe9 to 6dea953 Compare April 1, 2024 19:37
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule branch from 8c92b70 to 8315c7e Compare April 1, 2024 19:37
@@ -108,12 +108,11 @@ internal class PostgresUtilsTest {
}

companion object {
lateinit var PSQL_DB: PostgreSQLContainer<Nothing>
var PSQL_DB: PostgreSQLContainer<Nothing> = PostgreSQLContainer<Nothing>("postgres:13-alpine")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you could even call the start() method using run or apply or whichever scoped method is best and get rid of init() entirely.

@postamar postamar changed the title enabling postbugs for datastore-postgres submodule enabling spotbugs for datastore-postgres submodule Apr 2, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_spotbugs_for_gcs-destinations_submodule branch from 6dea953 to 9236984 Compare April 2, 2024 14:55
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule branch from 8315c7e to 34b730f Compare April 2, 2024 14:55
@stephane-airbyte stephane-airbyte marked this pull request as ready for review April 2, 2024 14:56
@stephane-airbyte stephane-airbyte requested review from a team as code owners April 2, 2024 14:56
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_spotbugs_for_gcs-destinations_submodule branch from 9236984 to 18c552f Compare April 2, 2024 18:07
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule branch from 34b730f to 8d4840e Compare April 2, 2024 18:07
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_spotbugs_for_gcs-destinations_submodule branch from 18c552f to 6105dec Compare April 2, 2024 18:09
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule branch from 8d4840e to 8b6a839 Compare April 2, 2024 18:09
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_spotbugs_for_gcs-destinations_submodule branch from 6105dec to af9fd95 Compare April 3, 2024 16:29
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule branch from 8b6a839 to 796089c Compare April 3, 2024 16:29
Copy link
Contributor Author

stephane-airbyte commented Apr 3, 2024

Merge activity

@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_spotbugs_for_gcs-destinations_submodule branch from af9fd95 to 47c584c Compare April 3, 2024 17:57
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule branch from 796089c to 910e05c Compare April 3, 2024 17:57
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_spotbugs_for_gcs-destinations_submodule branch from 47c584c to 72f4502 Compare April 3, 2024 21:32
Base automatically changed from stephane/03-28-enabling_spotbugs_for_gcs-destinations_submodule to master April 3, 2024 21:39
@stephane-airbyte stephane-airbyte force-pushed the stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule branch from 910e05c to 8d0610a Compare April 3, 2024 21:40
@stephane-airbyte stephane-airbyte merged commit 4d77401 into master Apr 3, 2024
27 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule branch April 3, 2024 21:48
nurikk pushed a commit to nurikk/airbyte that referenced this pull request Apr 4, 2024
markcusack pushed a commit to markcusack/airbyte that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants