enable spotbugs for db-sources submodule #36705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Mar 29, 2024
stephane-airbyte
force-pushed
the
stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule
branch
from
1c4ccac
to
8c92b70
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_db-sources_submodule
branch
from
d66224f
to
c2f86c1
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule
branch
from
8c92b70
to
8315c7e
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_db-sources_submodule
branch
from
c2f86c1
to
c08f788
Compare
postamar
approved these changes
Apr 2, 2024
| @@ -155,7 +155,7 @@ class PythonSourceAcceptanceTest : SourceAcceptanceTest() { | |||
| private val LOGGER: Logger = LoggerFactory.getLogger(PythonSourceAcceptanceTest::class.java) | |||
| private const val OUTPUT_FILENAME = "output.json" | |||
|
|
|||
| lateinit var IMAGE_NAME: String | |||
| var IMAGE_NAME: String = "dummy_image_name" | |||
There was a problem hiding this comment.
I was going to post a comment about how this is bad but then I noticed that this class was PythonSourceAcceptanceTest which assuredly is dead code.
stephane-airbyte
force-pushed
the
stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule
branch
from
8315c7e
to
34b730f
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_db-sources_submodule
branch
from
c08f788
to
185fc3b
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule
branch
from
34b730f
to
8d4840e
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule
branch
from
8d4840e
to
8b6a839
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_db-sources_submodule
branch
from
185fc3b
to
af00bdf
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule
branch
from
8b6a839
to
796089c
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_db-sources_submodule
branch
from
af00bdf
to
383be2e
Compare
Merge activity
|
stephane-airbyte
force-pushed
the
stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule
branch
from
796089c
to
910e05c
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_db-sources_submodule
branch
from
383be2e
to
3130d1c
Compare
stephane-airbyte
force-pushed
the
stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule
branch
from
910e05c
to
8d0610a
Compare
Base automatically changed from
stephane/03-28-enabling_postbugs_for_datastore-postgres_submodule
to
master
April 3, 2024 21:48
stephane-airbyte
force-pushed
the
stephane/03-28-enable_spotbugs_for_db-sources_submodule
branch
from
3130d1c
to
ca16f89
Compare
stephane-airbyte
deleted the
stephane/03-28-enable_spotbugs_for_db-sources_submodule
branch
nurikk
pushed a commit
to nurikk/airbyte
that referenced
this pull request
Apr 4, 2024
markcusack
pushed a commit
to markcusack/airbyte
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.