cdk publish: add required token to commit to master and --no-cache for getting just-published version from pypi #36864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @erohmensing and the rest of your teammates on |
|
/approve-and-merge reason="Continue to fix cdk publish pipeline" |
|
After a careful ML study, |
octavia-approvington
approved these changes
Apr 5, 2024
octavia-approvington
deleted the
ella/04-05-add-required-token-and---no-cache
branch
natikgadzhi
reviewed
Apr 5, 2024
| @@ -97,7 +97,7 @@ jobs: | |||
| with: | |||
| repository: ${{ github.event.inputs.repo }} | |||
| ref: ${{ github.event.inputs.gitref }} | |||
| token: ${{ secrets.GH_PAT_MAINTENANCE_OSS }} | |||
| token: ${{ secrets.GH_PAT_MAINTENANCE_OSS }} # This token is what allows us to commit directly to master | |||
| - name: "Publish Python CDK: bump Poetry package version" | |||
| id: bumpversion | |||
| run: | | |||
There was a problem hiding this comment.
Oh I love this, now I know where we have the logic that pushes the version into the Changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes to the workflow:
--no-cache, poetry's pypi cache immediately decides it can't find the new version that we just published in the previous step.--no-cacheforces it to pull the versions again. It's possible that by the time it does this, pypi won't have updated it yet in their apis - if so we'll need to add a timeout too. But we'll try this first.