-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdk publish: add required token to commit to master and --no-cache for getting just-published version from pypi #36864
cdk publish: add required token to commit to master and --no-cache for getting just-published version from pypi #36864
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @erohmensing and the rest of your teammates on |
/approve-and-merge reason="Continue to fix cdk publish pipeline" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the cleanup!
@@ -97,7 +97,7 @@ jobs: | |||
with: | |||
repository: ${{ github.event.inputs.repo }} | |||
ref: ${{ github.event.inputs.gitref }} | |||
token: ${{ secrets.GH_PAT_MAINTENANCE_OSS }} | |||
token: ${{ secrets.GH_PAT_MAINTENANCE_OSS }} # This token is what allows us to commit directly to master | |||
- name: "Publish Python CDK: bump Poetry package version" | |||
id: bumpversion | |||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I love this, now I know where we have the logic that pushes the version into the Changelog.
Some fixes to the workflow:
--no-cache
, poetry's pypi cache immediately decides it can't find the new version that we just published in the previous step.--no-cache
forces it to pull the versions again. It's possible that by the time it does this, pypi won't have updated it yet in their apis - if so we'll need to add a timeout too. But we'll try this first.