Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDK s3-destinations: fixes for s3 connector compilation #36868

Merged
merged 1 commit into from
Apr 8, 2024
Merged

CDK s3-destinations: fixes for s3 connector compilation #36868

merged 1 commit into from
Apr 8, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Apr 5, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 6:40pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Apr 5, 2024
@gisripa Graphite App
Copy link
Contributor Author

gisripa commented Apr 5, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@gisripa gisripa mentioned this pull request Apr 5, 2024
Merged
@gisripa gisripa changed the title cdk-s3-destinations-fixes CDK s3-destinations: fixes for s3 connector compilation Apr 5, 2024
@gisripa gisripa marked this pull request as ready for review April 5, 2024 18:46
@gisripa gisripa requested review from a team as code owners April 5, 2024 18:46
@gisripa gisripa force-pushed the gireesh/04-05-cdk-s3-destinations-fixes branch 3 times, most recently from 7a07bb3 to d3ef2dd Compare April 5, 2024 20:01
edgao
edgao approved these changes Apr 5, 2024
View reviewed changes
...n/io/airbyte/cdk/integrations/standardtest/destination/argproviders/DataArgumentsProvider.kt
@@ -43,6 +43,7 @@ class DataArgumentsProvider : ArgumentsProvider {
}

companion object {
@JvmField
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we wanted to avoid jvmfield? (from https://www.notion.so/Converting-the-Java-CDK-to-Kotlin-a29997b7bc7b40c689588e6ce4b1bb66)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To facilitate same pattern like ClassName.CONSTANT_STATIC_FIELD. without this it'll look like ClassName.Companion.getCONSTANT_STATIC_FIELD()

@gisripa gisripa force-pushed the gireesh/04-05-cdk-s3-destinations-fixes branch from d3ef2dd to 9f7a953 Compare April 6, 2024 01:27
gisripa
gisripa commented Apr 6, 2024
View reviewed changes
...res/kotlin/io/airbyte/cdk/integrations/standardtest/destination/DestinationAcceptanceTest.kt
@@ -429,6 +429,7 @@ abstract class DestinationAcceptanceTest {
val configuredCatalog = CatalogHelpers.toDefaultConfiguredCatalog(catalog)
val messages: List<io.airbyte.protocol.models.v0.AirbyteMessage> =
MoreResources.readResource(messagesFilename)
.trim()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a difference in String.java#lines() vs Kotlin's lines() which is emitting an extra empty string if there is \n at the end of file.

@gisripa gisripa force-pushed the gireesh/04-05-cdk-s3-destinations-fixes branch 2 times, most recently from 49efc12 to 38192b8 Compare April 8, 2024 18:26
@gisripa gisripa force-pushed the gireesh/04-05-cdk-s3-destinations-fixes branch from 38192b8 to a3a67e2 Compare April 8, 2024 18:40
@gisripa
Copy link
Contributor Author

gisripa commented Apr 8, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/8605131313
✅ Successfully published Java CDK version=0.29.8!

@gisripa gisripa merged commit f268be0 into master Apr 8, 2024
26 checks passed
@gisripa gisripa deleted the gireesh/04-05-cdk-s3-destinations-fixes branch April 8, 2024 18:50
markcusack pushed a commit to markcusack/airbyte that referenced this pull request Apr 9, 2024
@gisripa
CDK s3-destinations: fixes for s3 connector compilation (airbytehq#36868
fdd91aa 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gisripa @edgao @octavia-squidington-iii