Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination S3: Adapt kotlin CDK #36869

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Destination S3: Adapt kotlin CDK #36869

merged 1 commit into from
Apr 8, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Apr 5, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 7:00pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Apr 5, 2024
@gisripa Graphite App
Copy link
Contributor Author

gisripa commented Apr 5, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@gisripa gisripa mentioned this pull request Apr 5, 2024
Merged
@gisripa gisripa changed the title destinations-s3-cdk-upgrade Destination S3: Adapt kotlin CDK Apr 5, 2024
@gisripa gisripa marked this pull request as ready for review April 5, 2024 18:46
@gisripa gisripa requested a review from a team as a code owner April 5, 2024 18:46
@gisripa gisripa force-pushed the gireesh/04-05-cdk-s3-destinations-fixes branch from f10b9f5 to 3eda2a5 Compare April 5, 2024 19:12
@gisripa gisripa requested a review from a team as a code owner April 5, 2024 19:12
@gisripa gisripa force-pushed the gireesh/04-05-destinations-s3-cdk-upgrade branch from f2a632a to 0d01d6a Compare April 5, 2024 19:12
@gisripa gisripa force-pushed the gireesh/04-05-cdk-s3-destinations-fixes branch from 3eda2a5 to 7a07bb3 Compare April 5, 2024 19:32
@gisripa gisripa force-pushed the gireesh/04-05-destinations-s3-cdk-upgrade branch from 0d01d6a to 22bf871 Compare April 5, 2024 19:32
@gisripa gisripa force-pushed the gireesh/04-05-cdk-s3-destinations-fixes branch from 7a07bb3 to d3ef2dd Compare April 5, 2024 20:01
@gisripa gisripa force-pushed the gireesh/04-05-destinations-s3-cdk-upgrade branch from 22bf871 to fcee126 Compare April 5, 2024 20:01
evantahler
evantahler reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checking that moving to the new CDK doesn't implicitly add support for the Async framework or anything like that... that's a future project, yes?

@gisripa gisripa force-pushed the gireesh/04-05-cdk-s3-destinations-fixes branch from d3ef2dd to 9f7a953 Compare April 6, 2024 01:27
@gisripa gisripa force-pushed the gireesh/04-05-destinations-s3-cdk-upgrade branch from fcee126 to ed6d0dc Compare April 6, 2024 01:27
@gisripa
Copy link
Contributor Author

gisripa commented Apr 6, 2024 •
edited
Loading

Double checking that moving to the new CDK doesn't implicitly add support for the Async framework or anything like that... that's a future project, yes?

@evantahler Yes. well its not even an straightforward feat, our "Async" framework only works with the assumption of CSV Buffers atm. Just making it move ahead with main, so we can continue with required fixes for Parquet/Avro etc.

@gisripa gisripa force-pushed the gireesh/04-05-cdk-s3-destinations-fixes branch from 9f7a953 to 49efc12 Compare April 6, 2024 19:24
@gisripa gisripa force-pushed the gireesh/04-05-destinations-s3-cdk-upgrade branch from ed6d0dc to c272fdd Compare April 6, 2024 19:24
@gisripa
Copy link
Contributor Author

gisripa commented Apr 8, 2024

Parquet Run
Avro Run
CSV Run

@gisripa gisripa force-pushed the gireesh/04-05-cdk-s3-destinations-fixes branch from 49efc12 to 38192b8 Compare April 8, 2024 18:26
@gisripa gisripa force-pushed the gireesh/04-05-destinations-s3-cdk-upgrade branch from c272fdd to 6d82116 Compare April 8, 2024 18:26
@gisripa gisripa force-pushed the gireesh/04-05-cdk-s3-destinations-fixes branch from 38192b8 to a3a67e2 Compare April 8, 2024 18:40
Base automatically changed from gireesh/04-05-cdk-s3-destinations-fixes to master April 8, 2024 18:50
@gisripa gisripa force-pushed the gireesh/04-05-destinations-s3-cdk-upgrade branch from 6d82116 to 7860c19 Compare April 8, 2024 18:56
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 8, 2024
@gisripa gisripa merged commit 5ea2b93 into master Apr 8, 2024
29 checks passed
@gisripa gisripa deleted the gireesh/04-05-destinations-s3-cdk-upgrade branch April 8, 2024 19:15
markcusack pushed a commit to markcusack/airbyte that referenced this pull request Apr 9, 2024
@gisripa
Destination S3: Adapt kotlin CDK (airbytehq#36869)
7892297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler left review comments

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/s3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gisripa @evantahler @edgao @octavia-squidington-iii