-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Openweather: fix longitude parameter in spec #36876
🐛 Source Openweather: fix longitude parameter in spec #36876
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rwhwebster I'm going to run tests during the week to release a new version of the connector.
Thank you for the PR, @rwhwebster! |
Hello @rwhwebster your feedback matters a lot to us. Can you spare just 3 minutes to complete a survey? We're dedicated to making the contributor experience even better, and your input is key to achieving excellence. Thank you for helping us improve! |
Problem
fixes #36712
Existing configuration restricts usage of the longitude parameter to values that only contain 2 digits before the decimal point, preventing usage for locations with longitudes < -99 degrees and > 99 degrees.
Changes made
This PR includes an adjustment to the regex pattern for the latitude and longitude parameter to instead apply restrictions based on values being within +-90 degrees for latitude and +-180 degrees for longitude in the sources manifest.yaml
Where to look
Only code change is in the sources manifest.yaml; all other changes are documentation/version updates.
🚨 User Impact 🚨
No breaking changes; API calls would already fail if parameter values fell outside these ranges