🐛 Source Openweather: fix longitude parameter in spec #36876
Merged
+1,068
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
marcosmarxm
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Thanks @rwhwebster I'm going to run tests during the week to release a new version of the connector.
|
Thank you for the PR, @rwhwebster! |
|
Hello @rwhwebster your feedback matters a lot to us. Can you spare just 3 minutes to complete a survey? We're dedicated to making the contributor experience even better, and your input is key to achieving excellence. Thank you for helping us improve! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fixes #36712
Existing configuration restricts usage of the longitude parameter to values that only contain 2 digits before the decimal point, preventing usage for locations with longitudes < -99 degrees and > 99 degrees.
Changes made
This PR includes an adjustment to the regex pattern for the latitude and longitude parameter to instead apply restrictions based on values being within +-90 degrees for latitude and +-180 degrees for longitude in the sources manifest.yaml
Where to look
Only code change is in the sources manifest.yaml; all other changes are documentation/version updates.
🚨 User Impact 🚨
No breaking changes; API calls would already fail if parameter values fell outside these ranges