Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Fix empty internal_message empty when ExceptionWithDisplayMessage raised #36901

Merged
merged 3 commits into from Apr 9, 2024

Conversation

strosek
Copy link
Contributor

@strosek strosek commented Apr 8, 2024

Some exceptions raised are logged with an internal_message field empty in the concurrent CDK. This makes it hard to categorize and solve problems. issue 6830

What

Fixed empty internal_message fields when an ExceptionWithDisplayMessage is raised.

How

  • A __str__() implementation was added to ExceptionWithDisplayMessage to avoid empty internal_message fields
  • Added relevant unit test

🚨 User Impact 🚨

No breaking changes

@strosek strosek self-assigned this Apr 8, 2024
@strosek strosek requested a review from a team as a code owner April 8, 2024 19:27
Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 7:34pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Apr 8, 2024
@strosek strosek changed the title Fix empty internal_message empty when ExceptionWithDisplayMessage raised ✨ Fix empty internal_message empty when ExceptionWithDisplayMessage raised Apr 8, 2024
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Schedule something with me today or tomorrow so that we can view the release process for the CDK

@strosek strosek merged commit 23c280b into master Apr 9, 2024
28 checks passed
@strosek strosek deleted the strosek/conc-cdk-empty-exception-msgs branch April 9, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants