[ISSUE #6830] Bump salesforce CDK dependency and patch version #36937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
maxi297
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
LGTM!
Before you merge, can you add a bit more meat to the PR description? I usually like to use this kind of template where I explicitly mentioned what was done and how (which you have done) but also to describe 馃毃 User Impact 馃毃 i.e. how can we know the change worked, is the change breaking and can it be reverted if there is an issue. Note that there should always be a user impact as when we do a change, we expect it to deliver value.
Another note: I'm not the best to document PR as well so please keep me accountable on that as well.
strosek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump Salesforce source connector version (to 2.4.4) and CDK dependency (0.79.2) to include issue fixes in #36901
What
Some exceptions raised are logged with an internal_message field empty in the concurrent CDK. This makes it hard to categorize and solve problems. issue 6830
Fixed empty internal_message fields when an ExceptionWithDisplayMessage is raised.
How
A
__str__()implementation was added toExceptionWithDisplayMessageto avoid emptyinternal_messagefieldsAdded relevant unit test, which catches unhandled exceptions and traces them with the correct internal message.
馃毃 User Impact 馃毃
No breaking changes
Changes can be reverted