Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[source-lemlist] Add new columns for AB tests tracking #37100

Merged
merged 9 commits into from
Apr 30, 2024
Merged

[source-lemlist] Add new columns for AB tests tracking #37100

merged 9 commits into from
Apr 30, 2024

Conversation

tlfbrito
Copy link
Contributor

@tlfbrito tlfbrito commented Apr 12, 2024 •
edited
Loading

Add new columns (stepTested and sequenceTested)

API documentation: https://developer.lemlist.com/#get-activities

@vercel Vercel
Copy link

vercel bot commented Apr 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 6:05pm

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tlfbrito tlfbrito changed the title Add new columns for AB tests on lemlist activities.json Source Lemlist: Add new columns for AB tests tracking Apr 12, 2024
marcosmarxm
marcosmarxm requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the metadata version and the changelog entry in docs?

@marcosmarxm marcosmarxm changed the title Source Lemlist: Add new columns for AB tests tracking [source-lemlist] Add new columns for AB tests tracking Apr 15, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 15, 2024
@tlfbrito
Copy link
Contributor Author

Can you bump the metadata version and the changelog entry in docs?

Thanks for the review @marcosmarxm

@marcosmarxm
Copy link
Member

Running tests 🚀 ⌛

@marcosmarxm marcosmarxm merged commit 96c0154 into airbytehq:master Apr 30, 2024
30 of 31 checks passed
clnoll pushed a commit that referenced this pull request May 10, 2024
@tlfbrito @marcosmarxm @clnoll
[source-lemlist] Add new columns for AB tests tracking (#37100)
ff63168 
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/lemlist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tlfbrito @CLAassistant @marcosmarxm @octavia-squidington-iii