Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Facebook Marketing: add retry for transient error #37320

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

artem1205
Copy link
Collaborator

What

Resolve https://github.com/airbytehq/oncall/issues/4868

more context : https://github.com/airbytehq/oncall/issues/4951#issuecomment-2052067259

How

add retry for error with status_code == 400 and "cannot include ..."

[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 5:05pm

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 15, 2024
@artem1205 artem1205 self-assigned this Apr 15, 2024
@artem1205 artem1205 marked this pull request as ready for review April 15, 2024 15:14
@octavia-squidington-iv octavia-squidington-iv requested review from a team April 15, 2024 15:16
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval on better documentation in the repo

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 merged commit 8789eac into master Apr 16, 2024
29 checks passed
@artem1205 artem1205 deleted the artem1205/source-fb-marketing-OC-4951 branch April 16, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants