✨ Slack source: add support for optional private channels #37332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
marcosmarxm
requested changes
Apr 18, 2024
Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
irvingpop
force-pushed
the
slack_private_channels_lc
branch
from
3c84971
to
d466500
Compare
Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
octavia-squidington-iii
added
the
area/documentation
|
Done @marcosmarxm ! Thanks for taking a look |
marcosmarxm
approved these changes
Apr 19, 2024
irvingpop
changed the title
|
thanks for the approval @marcosmarxm ! What's the next step to getting this merged? I noticed some of the PR workflows still need approval. |
marcosmarxm
had a problem deploying
to
community-ci
GitHub Actions
Failure
marcosmarxm
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to optionally include Slack private channels for the new Slack low-code connector. Here's how it appears: