-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Slack source: add support for optional private channels #37332
✨ Slack source: add support for optional private channels #37332
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you bump the metadata connector version, run poetry and also add the entry in the changelog?
Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
3c84971
to
d466500
Compare
Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
Signed-off-by: Irving Popovetsky <irving@honeycomb.io>
Done @marcosmarxm ! Thanks for taking a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks for this contribution @irvingpop
thanks for the approval @marcosmarxm ! What's the next step to getting this merged? I noticed some of the PR workflows still need approval. |
This PR adds support to optionally include Slack private channels for the new Slack low-code connector. Here's how it appears: