Fix partitioned state saving issue #37389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Apr 18, 2024
strosek
pushed a commit
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently, we save the state as if the partition sync was always successful. If the partition failed, we should not close the partition
How
By adding a parameter that mentions if the sync was successful in the
PartitionCompleteSentinel.User Impact
The slices that are failing will retry on the next sync from now on. As for the other issues, we have two syncs that failed with system_errors since version 2.5.0. I'll identify the workspace and communicate with TCS for a reset. I'll also check the config errors but from a quick look at it, all of them did not occur during a sync so we should be good there.
Can this PR be safely reverted and rolled back?