Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to enable Test commands to run from forked branches. #3740

Merged
merged 3 commits into from
May 29, 2021

Conversation

davinchia
Copy link
Contributor

@davinchia davinchia commented May 29, 2021

What

Today the test/publish commands always pull from the airbyte repo regardless of where the PR branch lives in. This means we cannot run the test/publish command on forked PRs.

Configure the checkout action to pull from the PR branch's repository instead of always defaulting to the repository the PR lives in.

Ran one integration test to show this change is no-op if the PR branch is from the Airbyte repo. The real test is running this command on #3660 .

Pre-merge Checklist

  • Run integration tests

Recommended reading order

  1. Both files.

@davinchia davinchia changed the title Test and Publish command run from forked branches. Enable Test and Publish commands to run from forked branches. May 29, 2021
@davinchia
Copy link
Contributor Author

davinchia commented May 29, 2021

/test connector=source-file

Error: Workflow does not have 'workflow_dispatch' trigger

@davinchia
Copy link
Contributor Author

davinchia commented May 29, 2021

/test connector=source-file

🕑 source-file https://github.com/airbytehq/airbyte/actions/runs/888456392
✅ source-file https://github.com/airbytehq/airbyte/actions/runs/888456392

@davinchia davinchia changed the title Enable Test and Publish commands to run from forked branches. Try to enable Test commands to run from forked branches. May 29, 2021
@davinchia
Copy link
Contributor Author

davinchia commented May 29, 2021

/test connector=source-file

🕑 source-file https://github.com/airbytehq/airbyte/actions/runs/888480105
✅ source-file https://github.com/airbytehq/airbyte/actions/runs/888480105

@davinchia davinchia requested a review from sherifnada May 29, 2021 15:35
@davinchia davinchia marked this pull request as ready for review May 29, 2021 15:40
@auto-assign auto-assign bot requested a review from michel-tricot May 29, 2021 15:40
@davinchia davinchia removed the request for review from michel-tricot May 29, 2021 15:40
@davinchia davinchia merged commit 86e0b54 into master May 29, 2021
@davinchia davinchia deleted the davinchia/test-publish-command-forked-repo branch May 29, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant