-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 File source: Add support for Azure blob storage #3660
Conversation
I've successfully run the new integration tests locally, however I'm assuming I need to put the new Azure secrets somewhere so that the build can access them for the tests? |
@Phlair thank you! review coming shortly. in the meantime for this to run in CI can you add the @davinchia will take care of adding it to github secrets for you where it will be made available in Ci |
^ those creds are now in Lastpass :) |
/test connector=source-file
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks George!
One minor comment. Other than that, I want to wait for the integration test to succeed before merging this in.
airbyte-integrations/connectors/source-file/source_file/client.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Davin Chia <davinchia@gmail.com>
/test connector=source-file
|
This is passing even though I haven't yet added the secret because the workflow is set up to pull from our repo instead of the forked repo. |
/test connector=source-file
|
/test connector=source-file
|
/test connector=source-file repo=Phlair/airbyte
|
@Phlair sorry for the merge delay. I'm also using this PR as a way to refine our tooling around contribution from forked repos. I think I've gotten it mostly working - the current error is due to a bad dependency I fixed in the course of looking at this PR. Do you mind adding this to your changes so I can successfully build this? Happy to do so myself if you give me write permission to your fork! |
@davinchia No problem, happy to be part of progress 👍 |
/test connector=source-file repo=Phlair/airbyte
|
/test connector=source-file repo=Phlair/airbyte
|
/test connector=source-file repo=Phlair/airbyte
|
What
Adding to Files source connector, ability to grab from Azure Blob Storage
How
smart_open already supports Azure Blob so this was just a case of following existing structure of the Files source connector to create relevant AzBlob functions and integration tests (these required creating a storage account in Airbyte's Azure manually with user integration-test@airbyte.io to use for blob upload/read)
Pre-merge Checklist
Recommended reading order
test.java
component.ts