Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Linkedin Ads: fix changing next_page_token stopping criteria (test copy for #34166) #37421

Merged
merged 11 commits into from
Apr 19, 2024
Merged

🐛 Source Linkedin Ads: fix changing next_page_token stopping criteria (test copy for #34166) #37421

merged 11 commits into from
Apr 19, 2024
+29 −6

Conversation

natikgadzhi
Copy link
Contributor

@natikgadzhi natikgadzhi commented Apr 19, 2024 •
edited
Loading

See #34166

@FVidalCarneiro, thank you for contributing and for being patient with us!

@vercel Vercel
Copy link

vercel bot commented Apr 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 0:45am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/linkedin-ads labels Apr 19, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team April 19, 2024 00:27
@natikgadzhi natikgadzhi changed the title Test PR for 34166 🐛 Source Linkedin Ads: fix changing next_page_token stopping criteria (test copy for #34166) Apr 19, 2024
@natikgadzhi
Copy link
Contributor Author

@FVidalCarneiro, the only change that I needed to make here is to bump dockerImageTag in the metadata to 1.0.1, but otherwise, checks were fine. I'll merge this once checks pass.

@natikgadzhi natikgadzhi enabled auto-merge (squash) April 19, 2024 00:46
lazebnyi
lazebnyi approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@natikgadzhi natikgadzhi merged commit 80b1b1d into master Apr 19, 2024
32 of 33 checks passed
@natikgadzhi natikgadzhi deleted the fvidalcarneiro/fix-source-linkedin-ads-test branch April 19, 2024 11:39
strosek pushed a commit that referenced this pull request Apr 24, 2024
@natikgadzhi @FVidalCarneiro
@lazebnyi @strosek
🐛 Source Linkedin Ads: fix changing next_page_token stopping criteria…
985c6e0 
… (test copy for #34166) (#37421)

Co-authored-by: FVidalCarneiro <francisco.carneiro@agicap.com>
Co-authored-by: Serhii Lazebnyi <serhii.lazebnyi@globallogic.com>
@marcosmarxm marcosmarxm mentioned this pull request Apr 30, 2024
Closed
@kev-datams kev-datams mentioned this pull request Jul 17, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazebnyi lazebnyi lazebnyi approved these changes

@marcosmarxm marcosmarxm Awaiting requested review from marcosmarxm

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/linkedin-ads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@natikgadzhi @lazebnyi @octavia-squidington-iii @FVidalCarneiro