[connector-templates] Switch python destination template to generate pyproject.toml instead of setup.py and requirements.txt #37457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pyproject.toml instead of setup.py and requirements.txt Implements airbytehq#37420
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
natikgadzhi
approved these changes
Apr 20, 2024
There was a problem hiding this comment.
Really nice work, @szemek! Thank you for cleaning this up.
Suggestion is very nit, I'll merge as is.
airbyte-integrations/connector-templates/destination-python/README.md.hbs
Show resolved
Hide resolved
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
Does it have to be hbs, or can it just be json file? No customization in here.
There was a problem hiding this comment.
Honestly I think you can delete the file for now. Yes, we want credentials ideally, but no, destination acceptance tests are really not yet positioned to have good end to end tests. /cc @aaronsteers
strosek
pushed a commit
that referenced
this pull request
Apr 24, 2024
…pyproject.toml instead of setup.py and requirements.txt (#37457) Co-authored-by: Natik Gadzhi <natik@respawn.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implements #37420
How
setup.pyandrequirements.txtreplaced with pyproject.toml. Some extra changes are included to make it more similar with source connector.Review guide
User Impact
Changes affect only connector developers using destination-python template.
Can this PR be safely reverted and rolled back?