-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix kotlin warnings in db-sources CDK submodule #37482
fix kotlin warnings in db-sources CDK submodule #37482
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
076187f
to
e99cdaf
Compare
e99cdaf
to
05aa676
Compare
* | ||
* @return set of system namespaces(schemas) to be excluded | ||
*/ | ||
get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we might instead want preserve the comment as a comment on the val
itself.
On the other hand, this field is fairly self-explanatory. Up to you.
@@ -24,7 +24,7 @@ open class SourceStateIterator<T>( | |||
private var lastCheckpoint: Instant = Instant.now() | |||
|
|||
override fun computeNext(): AirbyteMessage? { | |||
var iteratorHasNextValue = false | |||
var iteratorHasNextValue: Boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi you can also var iteratorHasNextValue: Boolean = try { ...
though there's no benefit to readability whatsoever in this case
fixing kotlin warnings in CDK db-sources submodule
fixing kotlin warnings in CDK db-sources submodule
fixing kotlin warnings in CDK db-sources submodule