Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Bing Ads: add new properties for stream keyword_performance_report #37545

Merged
merged 13 commits into from Apr 29, 2024

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Apr 24, 2024

What

Original PR: #35878
Resolve #35877

How

Add new fields for stream keyword_performance_report :

  • CampaignStatus
  • TopImpressionRatePercent
  • AdGroupStatus
  • TrackingTemplate
  • BidStrategyType
  • AccountStatus
  • FinalUrl
  • AdType
  • KeywordLabels
  • FinalMobileUrl
  • Goal
  • GoalType
  • AbsoluteTopImpressionRatePercent
  • BaseCampaignId
  • AccountNumber
  • DestinationUrl

Review guide

  1. airbyte-integrations/connectors/source-bing-ads/source_bing_ads/schemas/keyword_performance_report.json

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

KimPlv and others added 6 commits March 25, 2024 14:16
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
…e/update_source_bing_ads

# Conflicts:
#	docs/integrations/sources/bing-ads.md
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 2:12pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 24, 2024
@artem1205 artem1205 self-assigned this Apr 24, 2024
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
…ce_bing_ads' into airbyte/update_source_bing_ads
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 marked this pull request as ready for review April 24, 2024 21:07
@octavia-squidington-iv octavia-squidington-iv requested review from a team April 24, 2024 21:08
@artem1205 artem1205 changed the title Airbyte/update source bing ads Source Bing Ads: add new properties for stream keyword_performance_report Apr 24, 2024
@artem1205 artem1205 requested a review from lazebnyi April 25, 2024 07:10
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 merged commit 7892328 into master Apr 29, 2024
34 of 35 checks passed
@artem1205 artem1205 deleted the airbyte/update_source_bing_ads branch April 29, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bing-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[source-bing-ads]: add missing fields for keyword_performance_report
4 participants