Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix missing slash command input args #37564

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

aaronsteers
Copy link
Collaborator

@aaronsteers aaronsteers commented Apr 25, 2024

What

Resolves an issue where an unused "pr" arg sent to a slash command would cause the workflow to fail.

How

Defines "pr" args and marks them unused and optional, when not used.

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 4:02pm

@aaronsteers aaronsteers marked this pull request as ready for review April 25, 2024 15:57
@aaronsteers aaronsteers requested a review from a team as a code owner April 25, 2024 15:57
@aaronsteers
Copy link
Collaborator Author

Merging to resolve breakage from last PR. This should be a no-op, except to make sure other slash commands don't fail.

@aaronsteers aaronsteers merged commit 5629bb9 into master Apr 25, 2024
30 of 31 checks passed
@aaronsteers aaronsteers deleted the aj/ci/fix-missing-slash-command-input-args branch April 25, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant