Python CDK: Pin the airbyte_protocol version #37679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
erohmensing
approved these changes
Apr 29, 2024
airbyte-cdk/python/pyproject.toml
Outdated
| @@ -24,7 +24,7 @@ keywords = ["airbyte", "connector-development-kit", "cdk"] | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.9" | |||
| airbyte-protocol-models = "*" | |||
| airbyte-protocol-models = "~0.9" | |||
There was a problem hiding this comment.
If you want to keep it under 1.0, but are okay with 0.10, 0.11 etc, this should be ^0.9.0
There was a problem hiding this comment.
... or that might be wrong specifically for 0 versions, now i'm confused
There was a problem hiding this comment.
I guess we can do >= 0.9.0, < 2.0
There was a problem hiding this comment.
yes... 7 commits for a 1-line change 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Pin the CDK's dependency on airbyte-protocol-models to
^0.9.0to avoid accidental breaking changes. We should implicitly bump to a major version if/when necessaryCan this PR be safely reverted and rolled back?