Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tagging for api sources (required reviewers) #37728

Merged
merged 1 commit into from
May 1, 2024
Merged

fix tagging for api sources (required reviewers) #37728

merged 1 commit into from
May 1, 2024

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Apr 30, 2024 •
edited
Loading

What

  • Handle tagging for API sources

How

  • critical connectors auto-tagged via CODEOWNERS
  • other api sources not auto-tagged at the moment, we can re-evaluate if we want it back

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@erohmensing erohmensing requested a review from a team as a April 30, 2024 21:45
@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 9:49pm

@erohmensing erohmensing mentioned this pull request Apr 30, 2024
Merged
2 tasks
@erohmensing Graphite App
Copy link
Contributor Author

erohmensing commented Apr 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @erohmensing and the rest of your teammates on Graphite Graphite

@erohmensing erohmensing mentioned this pull request Apr 30, 2024
Merged
2 tasks
maxi297
maxi297 approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the code ownership part of the change

@erohmensing Graphite App
Copy link
Contributor Author

erohmensing commented May 1, 2024 •
edited
Loading

Merge activity

  • May 1, 5:39 PM EDT: @erohmensing started a stack merge that includes this pull request via Graphite.
  • May 1, 5:49 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 1, 5:56 PM EDT: @erohmensing merged this pull request with Graphite.

Base automatically changed from ella/requiredreviewers to master May 1, 2024 21:48
@erohmensing erohmensing merged commit 6e6cc5c into master May 1, 2024
31 checks passed
@erohmensing erohmensing deleted the ella/apiconnectors branch May 1, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxi297 maxi297 maxi297 approved these changes

@bazarnov bazarnov bazarnov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erohmensing @maxi297 @bazarnov