Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File-based CDK: allow to merge schemas with nullable object values #37773

Merged
merged 1 commit into from
May 2, 2024

Conversation

askarpets
Copy link
Contributor

What

Fix for https://github.com/airbytehq/oncall/issues/4948

How

Allow to merge schemas during running discover command if they have fields with type on ["null", "object"]

Review guide

  1. schema_helpers.py
  2. test_schema_helpers.py

User Impact

No

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@askarpets askarpets self-assigned this May 2, 2024
@askarpets askarpets requested a review from a team as a code owner May 2, 2024 14:22
Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) May 2, 2024 2:22pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label May 2, 2024
@askarpets askarpets requested a review from clnoll May 2, 2024 14:22
Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @askarpets!

@askarpets askarpets merged commit 8ec438a into master May 2, 2024
33 checks passed
@askarpets askarpets deleted the file-based-cdk-fix-merge-schemas branch May 2, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants