Destination Snowflake: Use safe executeMetadataQuery call #37857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
|
doublechecking: resultSet.getMetadata() is safe? b/c presumably we're already inside a database.query() block (we have a few rs.getmetadata calls in various places) |
Yeah, as long as the rs is in try-with or |
evantahler
reviewed
May 6, 2024
Comment on lines
+136
to
+138
| LOGGER.info("Retrieving table from Db metadata: {} {}", | ||
| id.getRawNamespace(), | ||
| id.getRawName()); |
octavia-squidington-iii
added
the
area/documentation
clnoll
pushed a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
database.getMetadata()recycles the underlying connection object back into the pool (in hikari land) after the method call returns. DbMetadata holds an instance copy of that connection object and any subsequent calls which yield aResultSetcould potentially deadlock other calls using the same connection. This was already fixed inJdbcDestinationHandlerbut this call was missed out.Can this PR be safely reverted and rolled back?