Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata sensor to 2 min polling interval #38555

Merged
merged 1 commit into from
May 22, 2024

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented May 22, 2024

What

Decrease the polling interval from 5min to 2min

Why

We can now tighten up this interval as the job runs much faster.

The logic now takes < 10s

However the full run from resource spin up to spin down is 1.5 minutes.

Which is why I chose every 2 minutes and not every minute


Closes https://github.com/airbytehq/airbyte-internal-issues/issues/7820

@bnchrch bnchrch requested a review from a team as a code owner May 22, 2024 13:27
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) May 22, 2024 1:27pm

Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The benefit here is:

  • More frequent registry generation
  • Faster connector release
  • Faster feedback in #connector-publish-updates

Correct?

Copy link
Contributor Author

bnchrch commented May 22, 2024

@alafanechere Correct!

@bnchrch
Copy link
Contributor Author

bnchrch commented May 22, 2024

/approve-and-merge reason="hanging test that passes locally"

@octavia-approvington
Copy link
Contributor

A job well done
nice job

@octavia-approvington octavia-approvington merged commit 2331fc2 into master May 22, 2024
25 of 27 checks passed
@octavia-approvington octavia-approvington deleted the bnchrch/registry/update-metadata-poll branch May 22, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants