✨CAT: add test_primary_keys_data_type
#38755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
the
area/documentation
artem1205
approved these changes
May 30, 2024
lazebnyi
approved these changes
Jun 5, 2024
natikgadzhi
approved these changes
Jun 7, 2024
brianjlai
approved these changes
Jun 7, 2024
| @@ -83,6 +83,7 @@ class DiscoveryTestConfig(BaseConfig): | |||
| backward_compatibility_tests_config: BackwardCompatibilityTestsConfig = Field( | |||
| description="Configuration for the backward compatibility tests.", default=BackwardCompatibilityTestsConfig() | |||
| ) | |||
| skip_primary_keys_data_type_validation: Optional[bool] = Field(False, description="Skip primary keys data type validation") | |||
There was a problem hiding this comment.
Is there a reason why we made this one skip...? To make things more consistent, could we instead make this validate_primary_key_data_type and default to True.
lazebnyi
removed request for
girarda,
maxi297,
clnoll,
erohmensing and
oustynova
kabeer27
pushed a commit
to kabeer27/airbyte
that referenced
this pull request
Jun 12, 2024
Co-authored-by: Serhii Lazebnyi <serhii.lazebnyi@globallogic.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves:
How
TestDiscovery.test_primary_keys_data_type, which validates that primary keys are not of typearrayorobjectvalidate_primary_keys_data_typetoTestBasicRead.test_read, which validates that primary keys are not of typearrayorobjectin records and ensures that at least one primary key is non-null when there is a composite primary keyReview guide
tests/test_core.pyunit_tests/test_core.pyUser Impact
No user impact
Can this PR be safely reverted and rolled back?