🐛 Postgres Destination fails when the connection is persisted across steps #39365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
octavia-squidington-iii
added
area/connectors
kikoncuo
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
kikoncuo
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
|
@kikoncuo please sign the CLA and update the title and description to match guidelines. |
marcosmarxm
requested changes
Jun 10, 2024
...postgres/src/main/java/io/airbyte/integrations/destination/postgres/PostgresDestination.java
Show resolved
Hide resolved
kikoncuo
changed the title
kikoncuo
changed the title
Done! |
kikoncuo
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
kikoncuo
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
kikoncuo
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
kikoncuo
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
octavia-squidington-iii
added
the
area/documentation
kikoncuo
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
kikoncuo
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
kikoncuo
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
kikoncuo
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
…hat already exists
octavia-squidington-iii
added
CDK
kikoncuo
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
kikoncuo
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
|
@kikoncuo - just curious, which version/pass offering of postgres are you using that you saw this bug? |
|
@evantahler I'm using a new default supabase project which uses Postgres version 15.1.1.58 I also tried with an older project from a month ago which I successfully used to do multiple syncs, same problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#39364
When using PostgreSQL as a destination, we tried to recreate a postgreSQL function which leads to an SQL error which crashes the sync process.
How
We've modified the SQL query to either create or replace the function, not only create which would lead to an error if the function already existed
Review guide
Try to use PostgreSQL as a destination with any source
User Impact
The function may re-created the function when it's not needed, but this shouldn't happen anyway as it's only on the session, in case other errors happen related to re-using the session, this would not crash the connector
Can this PR be safely reverted and rolled back?