Source Hubspot (refactor): Remove deprecated state method calls #39432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
bazarnov
reviewed
Jun 18, 2024
There was a problem hiding this comment.
Let's have the Live-Testing run around this change, to see if it recognizes the STATE format change. @ChristoGrab
|
@bazarnov Linking the live test results here, everything seems to check out |
bazarnov
reviewed
Jun 19, 2024
airbyte-integrations/connectors/source-hubspot/integration_tests/abnormal_state.json
Show resolved
Hide resolved
bazarnov
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Source Hubspot was recently migrated to the
Checkpointimplementation of state management to leverage RFR for applicable streams. As such, the deprecatedget_updated_statemethod should no longer be used to determine state. This PR removes the references toget_updated_statein the connector, and enables CAT incremental tests, which were previously disabled due to overly long runtimes.How
get_updated_statemethod.acceptance-test-configabnormal_stateto the correct cursor fields and typessample_filestointegration_testsfolder for consistency. Deleted additional unused catalogs.User Impact
No impact. Link to regression test results
Can this PR be safely reverted and rolled back?