Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audrey/rbac #39501

Merged
merged 17 commits into from
Jun 20, 2024
Merged

Audrey/rbac #39501

merged 17 commits into from
Jun 20, 2024

Conversation

Adorism
Copy link
Contributor

@Adorism Adorism commented Jun 14, 2024 •
edited
Loading

What

Updating Security doc and adding a page for details on available RBAC roles

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Jun 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 5:39pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 14, 2024
teallarson
teallarson reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really glad to be getting this into the docs! A couple of notes.

docs/access-management/rbac.md Outdated Show resolved Hide resolved
docs/access-management/rbac.md Outdated Show resolved Hide resolved
@Adorism Adorism requested review from teallarson and rwask June 14, 2024 16:46
@Hesperide Hesperide self-requested a review June 14, 2024 17:24
@Adorism Adorism requested a review from Hesperide June 19, 2024 13:35
@Adorism Adorism marked this pull request as ready for review June 19, 2024 13:35
Adorism and others added 3 commits June 20, 2024 10:15
@Adorism @Hesperide
Update docs/access-management/rbac.md
1716d56 
Co-authored-by: Alexandre Cuoci <Hesperide@users.noreply.github.com>
@Adorism @Hesperide
Update docs/access-management/rbac.md
64d8e8f 
Co-authored-by: Alexandre Cuoci <Hesperide@users.noreply.github.com>
@Adorism
changes for review
9ea3fdb
@Adorism Adorism requested a review from Hesperide June 20, 2024 16:42
Hesperide
Hesperide approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@Hesperide Hesperide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@Adorism Adorism merged commit 39b3fee into master Jun 20, 2024
26 checks passed
@Adorism Adorism deleted the audrey/rbac branch June 20, 2024 18:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hesperide Hesperide Hesperide approved these changes

@timroes timroes Awaiting requested review from timroes

@johnwasserman johnwasserman Awaiting requested review from johnwasserman

@teallarson teallarson Awaiting requested review from teallarson

@rwask rwask Awaiting requested review from rwask

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Adorism @Hesperide @teallarson @octavia-squidington-iii