Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 New Source: IBM DB2 #4197

Merged
merged 8 commits into from
Jun 23, 2021
Merged

🎉 New Source: IBM DB2 #4197

merged 8 commits into from
Jun 23, 2021

Conversation

irynakruk
Copy link
Contributor

@irynakruk irynakruk commented Jun 18, 2021 •
edited
Loading

What

New source to integrate with IBM Db2

How

  1. Generated jdbc connector and implemented connections based on Db2 jdbc driver
  2. Created unit tests
  3. Created Integration tests (container for tests https://www.testcontainers.org/modules/databases/db2/)
  4. Created Comprehensive tests

Recommended reading order

  1. x.java
  2. else

Pre-merge Checklist

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in output spec
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Documentation updated
    • README
    • CHANGELOG.md
    • Reference docs in the docs/integrations/ directory.
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 18, 2021
@irynakruk irynakruk closed this Jun 18, 2021
@irynakruk irynakruk reopened this Jun 18, 2021
@irynakruk irynakruk marked this pull request as draft June 18, 2021 09:37
@irynakruk irynakruk linked an issue Jun 18, 2021 that may be closed by this pull request
New Source: IBM DB2 #2975
Closed
yaroslav-hrytsaienko
yaroslav-hrytsaienko approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@yaroslav-hrytsaienko yaroslav-hrytsaienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@irynakruk great pr! Meanwhile i did not found the table with use cases for comprehensive data types. Can you please add it with a comment to a ticket? Thanks!

@irynakruk
Copy link
Contributor Author

irynakruk commented Jun 18, 2021 •
edited
Loading

@irynakruk great pr! Meanwhile i did not found the table with use cases for comprehensive data types. Can you please add it with a comment to a ticket? Thanks!

@yaroslav-hrytsaienko Thanks for a fast review!
Sure, I added table with use cases directly to the ticket:
#2975 (comment)

sherifnada
sherifnada reviewed Jun 22, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also add this to docs/integrations/README.md as a beta connector

airbyte-integrations/connectors/source-db2/CHANGELOG.md Show resolved Hide resolved
sherifnada
sherifnada approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done @irynakruk !

@irynakruk irynakruk marked this pull request as ready for review June 22, 2021 16:50
@irynakruk
Copy link
Contributor Author

irynakruk commented Jun 22, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/961459572
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/961459572

@irynakruk
Copy link
Contributor Author

irynakruk commented Jun 22, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/961527571
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/961527571

@irynakruk
Copy link
Contributor Author

irynakruk commented Jun 22, 2021 •
edited
Loading

/test connector=connectors/source-postgres

@irynakruk
Copy link
Contributor Author

irynakruk commented Jun 22, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/961886049
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/961886049

@irynakruk
Copy link
Contributor Author

irynakruk commented Jun 23, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/963845318
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/963845318

@irynakruk irynakruk merged commit 0a4712c into master Jun 23, 2021
@irynakruk irynakruk deleted the irynakruk/2975-db2-source branch June 23, 2021 15:06
@mrmelon-xyz
Copy link

mrmelon-xyz commented Apr 8, 2022 •
edited
Loading

Hi there, Is there any plan to add CDC support to this connector? Thanks

@sherifnada
Copy link
Contributor

@mrmelon-xyz there is no timeline at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@yaroslav-hrytsaienko yaroslav-hrytsaienko yaroslav-hrytsaienko approved these changes

@subodh1810 subodh1810 Awaiting requested review from subodh1810

@tuliren tuliren Awaiting requested review from tuliren

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/db2 connectors/sources-database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Source: IBM DB2
5 participants
@irynakruk @mrmelon-xyz @sherifnada @yaroslav-hrytsaienko @karinakuz