Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump source Harvest docker version #4274

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Conversation

htrueman
Copy link
Contributor

@htrueman htrueman commented Jun 22, 2021

What

Bump Harvest docker version, based on #4248 changes.

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in output spec
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Documentation updated
    • README
    • CHANGELOG.md
    • Reference docs in the docs/integrations/ directory.
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Jun 22, 2021
@htrueman
Copy link
Contributor Author

htrueman commented Jun 22, 2021

/publish connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/961306969
✅ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/961306969

@htrueman
Copy link
Contributor Author

htrueman commented Jun 22, 2021

/test connector=source-harvest

🕑 source-harvest https://github.com/airbytehq/airbyte/actions/runs/961329699
✅ source-harvest https://github.com/airbytehq/airbyte/actions/runs/961329699

@marcosmarxm
Copy link
Member

@htrueman is possible to add the new version to CHANGELOG section https://github.com/airbytehq/airbyte/blob/master/docs/integrations/sources/harvest.md thanks

@htrueman htrueman merged commit d0a1550 into master Jun 22, 2021
@htrueman htrueman deleted the htrueman/bump-harvest-version branch June 22, 2021 16:59
@sherifnada sherifnada added this to the Connectors June 25, 2021 milestone Jun 23, 2021
@sherifnada sherifnada removed this from the Connectors July 9, 2021 milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants