Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Google Ads: support new report streams #4962

Merged
merged 11 commits into from
Jul 28, 2021
Merged

Source Google Ads: support new report streams #4962

merged 11 commits into from
Jul 28, 2021

Conversation

yevhenii-ldv
Copy link
Contributor

What

closes #4862.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

ykurochkin added 9 commits July 16, 2021 18:53
Source Google Ads: support new streams: Campaigns, Ads, Ad Groups, Ac…
bb6e77f 
…counts
update after review
a3e1cc7
Merge branch 'master' of github.com:airbytehq/airbyte into ykurochkin…
a8875e7 
…/source-google-ads-expand-api-support
fix issue #4806
c20aba2
Google Ads Reports: draft version
6709433
second version
f3f50a7
working version
497bc03
Merge branch 'master' of github.com:airbytehq/airbyte into ykurochkin…
c81efac 
…/source-google-ads-support-reports

� Conflicts:
�	airbyte-integrations/connectors/source-google-ads/integration_tests/configured_catalog.json
�	airbyte-integrations/connectors/source-google-ads/source_google_ads/google_ads.py
�	airbyte-integrations/connectors/source-google-ads/source_google_ads/schemas/accounts.json
�	airbyte-integrations/connectors/source-google-ads/source_google_ads/schemas/ad_group_ad_report.json
�	airbyte-integrations/connectors/source-google-ads/source_google_ads/schemas/ad_group_ads.json
�	airbyte-integrations/connectors/source-google-ads/source_google_ads/schemas/ad_groups.json
�	airbyte-integrations/connectors/source-google-ads/source_google_ads/schemas/campaigns.json
�	airbyte-integrations/connectors/source-google-ads/source_google_ads/source.py
�	airbyte-integrations/connectors/source-google-ads/source_google_ads/streams.py
�	airbyte-integrations/connectors/source-google-ads/unit_tests/test_google_ads.py
update docs
c634d34
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 23, 2021
@yevhenii-ldv yevhenii-ldv changed the title Ykurochkin/source google ads support reports Source Google Ads: support new report streams Jul 23, 2021
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jul 26, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1066434523
❌ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1066434523

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jul 26, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1066467471
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1066467471

Zirochkaa
Zirochkaa approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@Zirochkaa Zirochkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cheyura
Copy link

cheyura commented Jul 26, 2021 •
edited
Loading

Hi! Could anybody advise on dev app status - which account do you use for dev applications?

@tuliren
Copy link
Contributor

tuliren commented Jul 27, 2021

Hi! Could anybody advise on dev app status - which account do you use for dev applications?

We have individual accounts for each application. If an application offers a dev or testing account, we would use it. Otherwise, we just use a routine account that can be created from the application's website.

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jul 28, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1074657361
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1074657361

@yevhenii-ldv yevhenii-ldv merged commit c525dde into master Jul 28, 2021
@yevhenii-ldv yevhenii-ldv deleted the ykurochkin/source-google-ads-support-reports branch July 28, 2021 11:21
@zestyping zestyping mentioned this pull request Aug 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@htrueman htrueman htrueman approved these changes

@Zirochkaa Zirochkaa Zirochkaa approved these changes

@avida avida Awaiting requested review from avida

@ChristopheDuong ChristopheDuong Awaiting requested review from ChristopheDuong

@tuliren tuliren Awaiting requested review from tuliren

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀Source Google Ads: Support Reports
6 participants
@yevhenii-ldv @cheyura @tuliren @sherifnada @htrueman @Zirochkaa