Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT: remove deprecated validate_output_from_all_streams from configs #5010

Merged
merged 2 commits into from Jul 27, 2021

Conversation

keu
Copy link
Contributor

@keu keu commented Jul 27, 2021

What

This PR #4897:

  • deprecates validate_output_from_all_streams config option, this option is always ON now
  • introduces empty_streams config option with default value = True

Just removing deprecated validate_output_from_all_streams should be enough to fix the configs. Later we might revisit some catalogs to exclude empty streams in the config instead of excluding it from configured catalogs.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

@keu keu added the Acceptance Tests https://docs.google.com/document/d/1pFLR8eLP5VOj6vDtWe69KZL0aWWHEA6Vkbod6NYJon4/edit# label Jul 27, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Jul 27, 2021
@keu keu self-assigned this Jul 27, 2021
@sherifnada
Copy link
Contributor

@keu can you include a PR description before merging? I just realized that while I may know the context into this, others might not which makes it less accessible for them to review/understand

@avida
Copy link
Contributor

avida commented Jul 27, 2021

@keu Can we combine your PR with this one #4907 ? It removes unused json_schema parameter from config file

@keu
Copy link
Contributor Author

keu commented Jul 27, 2021

@keu Can we combine your PR with this one #4907 ? It removes unused json_schema parameters from the config file

I would love to, but this #5012 should fix the dummy test issue.

@keu keu merged commit 9de5368 into master Jul 27, 2021
@keu keu deleted the keu/sat-fix-deprecated-config branch July 27, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acceptance Tests https://docs.google.com/document/d/1pFLR8eLP5VOj6vDtWe69KZL0aWWHEA6Vkbod6NYJon4/edit# area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants