Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT: remove deprecated validate_output_from_all_streams from configs #5010

Merged
merged 2 commits into from
Jul 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -15,7 +15,6 @@ tests:
# basic_read:
# - config_path: "secrets/config.json"
# configured_catalog_path: "integration_tests/configured_catalog.json"
# validate_output_from_all_streams: yes
# incremental:
# - config_path: "secrets/config.json"
# configured_catalog_path: "integration_tests/configured_catalog.json"
Expand Down
Expand Up @@ -12,7 +12,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/streams_with_output_records_catalog.json"
validate_output_from_all_streams: yes
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog_without_events.json"
Expand Down
Expand Up @@ -14,7 +14,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
# TODO uncomment this block to specify that the tests should assert the connector outputs the records provided in the input file a file
# expect_records:
# path: "integration_tests/expected_records.txt"
Expand Down
Expand Up @@ -20,7 +20,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Expand Up @@ -14,7 +14,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "sample_files/configured_catalog.json"
validate_output_from_all_streams: yes
# TODO uncomment this block to specify that the tests should assert the connector outputs the records provided in the input file a file
# expect_records:
# path: "integration_tests/expected_records.txt"
Expand Down
Expand Up @@ -14,7 +14,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
# TODO uncomment this block to specify that the tests should assert the connector outputs the records provided in the input file a file
# expect_records:
# path: "integration_tests/expected_records.txt"
Expand Down
Expand Up @@ -14,7 +14,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
# FB serializes numeric fields as strings
validate_schema: no
incremental:
Expand Down
Expand Up @@ -12,12 +12,10 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/small_streams_configured_catalog.json"
validate_output_from_all_streams: yes
# Below streams have too much records and because of it we are getting timeouts and hitting rate limits.
# That's why we turned them off.
# - config_path: "secrets/config.json"
# configured_catalog_path: "integration_tests/too_large_streams_configured_catalog.json"
# validate_output_from_all_streams: yes
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/incremental_configured_catalog.json"
Expand Down
Expand Up @@ -12,7 +12,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
# We cannot use these tests for testing Incremental, since for Gitlab the State is saved for each Project separately,
# and the Acceptance Tests at this stage do not support this functionality.
# Therefore, we hardcode the cursor_paths for our config.
Expand Down
Expand Up @@ -12,7 +12,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Expand Down
Expand Up @@ -16,7 +16,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
# Temporary disabled. Singer Tap returns state with "bookmarks" root element, which causes error.
# incremental:
# - config_path: "secrets/config.json"
Expand Down
Expand Up @@ -12,7 +12,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "sample_files/configured_catalog.json"
validate_output_from_all_streams: yes
# Commented out due to the state structure is not supported by the SAT
# incremental:
# - config_path: "secrets/config.json"
Expand Down
Expand Up @@ -12,7 +12,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Expand Down
Expand Up @@ -13,7 +13,6 @@ tests:
- config_path: "secrets/config.json"
# TODO: permissions error with Workflows stream for Test Account
configured_catalog_path: "sample_files/configured_catalog_without_workflows.json"
validate_output_from_all_streams: yes
# incremental: fixme (eugene): '<=' not supported between instances of 'int' and 'str'
# - config_path: "secrets/config.json"
# configured_catalog_path: "sample_files/configured_catalog.json"
Expand Down
Expand Up @@ -14,7 +14,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog_without_stories.json"
validate_output_from_all_streams: yes
# disabled because the only incremental stream is user_insights and its state is nested
# incremental:
# - config_path: "secrets/config.json"
Expand Down
Expand Up @@ -14,7 +14,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Expand All @@ -28,4 +27,4 @@ tests:
segments: ["updated_at"]
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Expand Up @@ -15,24 +15,18 @@ tests:
# TEST for the Labels stream
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/labels_catalog.json"
validate_output_from_all_streams: yes
expect_records:
path: "integration_tests/expected_label_records.txt"
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/issues_configured_catalog.json"
validate_output_from_all_streams: yes
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/issue_worklogs_configured_catalog.json"
validate_output_from_all_streams: yes
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/projects_configured_catalog.json"
validate_output_from_all_streams: yes
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/workflows_configured_catalog.json"
validate_output_from_all_streams: yes
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
# incremental:
# - config_path: "secrets/config.json"
# configured_catalog_path: "integration_tests/full_configured_catalog.json"
Expand Down
Expand Up @@ -14,7 +14,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Expand Down
Expand Up @@ -12,7 +12,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
# THIS TEST IS COMMENTED OUT. Tests are supposed to accept
# `state = {cursor_field: value}`. When we have dependent endpoint path
# `path_begin/{some_id}/path_end` we need a complex state like below:
Expand Down
Expand Up @@ -14,7 +14,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Expand Down
Expand Up @@ -12,7 +12,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Expand Up @@ -15,7 +15,6 @@ tests:
# Sometimes test could fail (on weekends) because transactions could temporary disappear from Paypal Sandbox account
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Expand Down
Expand Up @@ -12,7 +12,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/streams_with_output_records_catalog.json"
validate_output_from_all_streams: yes
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/streams_with_output_records_catalog.json"
Expand Down
Expand Up @@ -12,7 +12,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "sample_files/no_spam_reports_configured_catalog.json"
validate_output_from_all_streams: yes
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "sample_files/no_spam_reports_configured_catalog.json"
Expand Down
Expand Up @@ -12,7 +12,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Expand Down
Expand Up @@ -12,7 +12,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
# We cannot use these tests for testing Incremental,
# since for Surveymonkey the State is saved for each Survey separately,
# and the Acceptance Tests at this stage do not support this functionality.
Expand Down
Expand Up @@ -12,7 +12,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/no_empty_streams_catalog.json"
validate_output_from_all_streams: yes
incremental:
- config_path: "secrets/config.json"
# usage records stream produces and error if cursor date gte than current date
Expand Down
Expand Up @@ -12,7 +12,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
# incremental test doesn't work if a single stream has multiple states right now
#incremental:
# - config_path: "secrets/config.json"
Expand Down
Expand Up @@ -14,7 +14,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Expand Up @@ -12,7 +12,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "sample_files/configured_catalog.json"
validate_output_from_all_streams: yes
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "sample_files/configured_catalog.json"
Expand Down
Expand Up @@ -14,7 +14,6 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
validate_output_from_all_streams: yes
# incremental: # complex state ( {parent_id: {cur_field: value}} still not supported )
# - config_path: "secrets/config.json"
# configured_catalog_path: "integration_tests/configured_catalog.json"
Expand Down