-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source HubSpot: Fix empty string
inside number / float
datatype
#5334
Conversation
…, added check for empty string for float type, added unit test
…ot-bad-double-values
bad double values
when sync with BigQuery destinationempty string
inside number / float
datatype
/test connector=connectors/source-hubspot
|
airbyte-integrations/connectors/source-hubspot/unit_tests/test_field_type_converting.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-hubspot/source_hubspot/api.py
Outdated
Show resolved
Hide resolved
…ov/5293-hubspot-bad-double-values
/test connector=connectors/source-hubspot
|
/publish connector=connectors/source-hubspot
|
What
#5293 - Source Hubspot fails in normalization step
How
field_value
verification for anempty string
toapi.py
, if so - set thefield_value
to be zero, instead of empty string.test_field_type_converting.py
unit-test to simulate the issue ofempty string
insidenumeric (float)
typeNOTE:
This fix potentially could resolve the issue with
Bad Double Value
when using this connector along withDestination BigQuery
for data replication. As far as BigQuery does not accept simplenull
values, and could not accept empty strings as numeric values, it requires additional data preprocessing before inject the data into the table.Pre-merge Checklist
Updating a connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here