Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Source MySQL - added option to connect using SSL #6510

Merged
merged 6 commits into from
Sep 30, 2021

Conversation

etsybaev
Copy link
Contributor

@etsybaev etsybaev commented Sep 28, 2021

What

We want to support TLS encryption when connecting to the MySQL source.

How

Added option to connect using SSL.
Note that we do NOT support certificate verification as part of this issue -- just encryption of data over the wire. In other words, the focus is protecting against eavesdropping, not man-in-the-middle attacks.

Tested with a testcontainer. It appears that it already contains some certificates
Selection_067
Selection_069
Selection_070

Also checked that If SSL is disabled on DB side - then Airbyte will show an error on UI on check connection stage
Selection_066

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Sep 28, 2021
@etsybaev etsybaev linked an issue Sep 28, 2021 that may be closed by this pull request
5 tasks
@CLAassistant
Copy link

CLAassistant commented Sep 28, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ etsybaev
❌ ievgeniit


ievgeniit seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@etsybaev etsybaev temporarily deployed to more-secrets September 28, 2021 15:32 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets September 28, 2021 16:27 Inactive
@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 28, 2021

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1283612658
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1283612658
No Python unittests run

@etsybaev etsybaev changed the title [DRAFT_PR] Source MySQL - added option to connect using ssl [DRAFT_PR] 🎉Source MySQL - added option to connect using ssl Sep 28, 2021
@jrhizor jrhizor temporarily deployed to more-secrets September 28, 2021 17:20 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets September 28, 2021 18:50 Inactive
@etsybaev etsybaev changed the title [DRAFT_PR] 🎉Source MySQL - added option to connect using ssl [DRAFT_PR] 🎉Source MySQL - added option to connect using SSL Sep 29, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 29, 2021
@etsybaev etsybaev temporarily deployed to more-secrets September 29, 2021 06:51 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets September 29, 2021 07:54 Inactive
@etsybaev etsybaev changed the title [DRAFT_PR] 🎉Source MySQL - added option to connect using SSL 🎉Source MySQL - added option to connect using SSL Sep 29, 2021
@etsybaev etsybaev temporarily deployed to more-secrets September 29, 2021 13:13 Inactive
@etsybaev etsybaev marked this pull request as ready for review September 29, 2021 13:15
Copy link
Contributor

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have two minor suggestions:

  1. For consistency, can MySqlSSLSourceAcceptanceTest be renamed to MySqlSslSourceAcceptanceTest.java? (SSL -> Ssl)
  2. As mentioned in the comment, verifyServerCertificate=false should be included in the unit test to fully match the code.

@etsybaev etsybaev temporarily deployed to more-secrets September 30, 2021 07:28 Inactive
@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 30, 2021

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1290177112
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1290177112
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets September 30, 2021 08:13 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets September 30, 2021 09:47 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets September 30, 2021 10:48 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets September 30, 2021 12:49 Inactive
@etsybaev
Copy link
Contributor Author

etsybaev commented Sep 30, 2021

/publish connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1291371907
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1291371907

@jrhizor jrhizor temporarily deployed to more-secrets September 30, 2021 14:08 Inactive
@etsybaev etsybaev merged commit 7698a50 into master Sep 30, 2021
@etsybaev etsybaev deleted the etsybaev/6010-source-mysql-added-ssl branch September 30, 2021 15:23
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* Source MySQL - added option to connect using SSL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for MySQL source via TLS/SSL
5 participants