-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉Source MySQL - added option to connect using SSL #6510
Conversation
ievgeniit seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
/test connector=connectors/source-mysql
|
airbyte-integrations/connectors/source-mysql/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have two minor suggestions:
- For consistency, can
MySqlSSLSourceAcceptanceTest
be renamed toMySqlSslSourceAcceptanceTest.java
? (SSL
->Ssl
) - As mentioned in the comment,
verifyServerCertificate=false
should be included in the unit test to fully match the code.
.../connectors/source-mysql/src/main/java/io/airbyte/integrations/source/mysql/MySqlSource.java
Outdated
Show resolved
Hide resolved
.../connectors/source-mysql/src/main/java/io/airbyte/integrations/source/mysql/MySqlSource.java
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-mysql/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
...test-integration/java/io/airbyte/integrations/source/mysql/MySqlSSLSourceAcceptanceTest.java
Outdated
Show resolved
Hide resolved
...sql/src/test/java/io/airbyte/integrations/source/mysql/MySqlSSLJdbcSourceAcceptanceTest.java
Outdated
Show resolved
Hide resolved
/test connector=connectors/source-mysql
|
/publish connector=connectors/source-mysql
|
* Source MySQL - added option to connect using SSL
What
We want to support TLS encryption when connecting to the MySQL source.
How
Added option to connect using SSL.
Note that we do NOT support certificate verification as part of this issue -- just encryption of data over the wire. In other words, the focus is protecting against eavesdropping, not man-in-the-middle attacks.
Tested with a testcontainer. It appears that it already contains some certificates
Also checked that If SSL is disabled on DB side - then Airbyte will show an error on UI on check connection stage
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here