Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accept-terms property to databricks spec #6792

Merged
merged 4 commits into from
Oct 5, 2021
Merged

Add accept-terms property to databricks spec #6792

merged 4 commits into from
Oct 5, 2021

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Oct 5, 2021 •
edited
Loading

What

  • Add a new property to ask users to accept the Databricks JDBC Driver terms and conditions.
  • Users already accepted these terms when they sign up. But we add it here for extra legal safety.

TODO

  • Update configs in Github secrets and Lastpass.

Screenshot

Screen Shot 2021-10-05 at 11 44 59

Open questions

  • We should check if there are existing cloud users for this connector. Otherwise, we cannot make this new property a required field.
  • Is it alright to default this property to false? I imagine people will forget to check this, and have a failed run because of it.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 5, 2021
@tuliren tuliren temporarily deployed to more-secrets October 5, 2021 18:43 Inactive
@tuliren tuliren temporarily deployed to more-secrets October 5, 2021 18:44 Inactive
@tuliren tuliren temporarily deployed to more-secrets October 5, 2021 19:12 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Oct 5, 2021

Integration tests passed locally:

Screen Shot 2021-10-05 at 12 37 55

@tuliren tuliren merged commit 914531c into master Oct 5, 2021
@tuliren tuliren deleted the liren/add-tos-field-to-databricks branch October 5, 2021 19:38
@jrhizor jrhizor mentioned this pull request Oct 5, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@tuliren @schlattk
Add accept-terms property to databricks spec (airbytehq#6792)
0207dc1 
* Add accept-terms property to databricks spec

* Update PR id

* Update version

* Update sample config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@Phlair Phlair Awaiting requested review from Phlair

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuliren @sherifnada