🎉 Source Looker: Migrate Looker source to CDK structure, add SAT testing #7284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/connectors
|
/test connector=connectors/source-looker
|
htrueman
approved these changes
Oct 25, 2021
Comment on lines
+18
to
+25
| [ | ||
| "homepages", | ||
| "looks", | ||
| "run_looks", | ||
| "scheduled_plans", | ||
| "user_attribute_group_values", | ||
| "user_login_lockouts", | ||
| "user_sessions", |
There was a problem hiding this comment.
Do we have an issue to fill those streams?
There was a problem hiding this comment.
Several of these streams are dynamic. But in the scope of this task, I did not fill the account with data.
avida
suggested changes
Oct 25, 2021
| dependencies { | ||
| implementation files(project(':airbyte-integrations:bases:base-standard-source-test-file').airbyteDocker.outputs) | ||
| implementation files(project(':airbyte-integrations:bases:base-python').airbyteDocker.outputs) | ||
| implementation files(project(':airbyte-integrations:bases:source-acceptance-test').airbyteDocker.outputs) |
There was a problem hiding this comment.
We don't really need this dependency cause we are using SAT image from dockerhub
| @@ -22,7 +22,7 @@ | |||
| } | |||
| }, | |||
| "type": ["null", "object"], | |||
| "additionalProperties": false | |||
| "additionalProperties": true | |||
There was a problem hiding this comment.
just remove additionalProperties, its true by default.
| }, | ||
| "type": ["null", "array"] | ||
| }, | ||
| "external_id": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "id": { | ||
| "type": ["null", "string"] | ||
| "type": ["null", "string", "integer"] |
There was a problem hiding this comment.
Can we leave it as string and enbale default schema type transformation ? It looks like primary key and its better to have one type here.
There was a problem hiding this comment.
This connector is custom written and did not use the Stream class from the Airbyte CDK, so unfortunately we cannot apply this approach to it.
|
/test connector=connectors/source-looker
|
avida
approved these changes
Oct 25, 2021
…urochkin/source-looker-refactor-to-use-cdk
|
/test connector=connectors/source-looker
|
|
/publish connector=connectors/source-looker
|
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
…ing (airbytehq#7284) * Migrate Looker source to CDK structure, add SAT testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
resolves #7246 .
How
Describe the solution
Recommended reading order
x.javay.pythonPre-merge Checklist
Expand the relevant checklist and delete the others.
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described here