-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Zendesk-Chat: add oauth flow support #7313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the old auth logic. I'm not sure to its current access_token is not compatible with oauths one.
And we should to test both config combinations. (old and new format)
airbyte-integrations/connectors/source-zendesk-chat/source_zendesk_chat/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-chat/source_zendesk_chat/spec.json
Show resolved
Hide resolved
/test connector=connectors/source-zendesk-chat
|
/test connector=connectors/source-zendesk-chat
|
/test connector=connectors/source-zendesk-chat
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Old spec config are compatible with the new one. And there is a corresponding test.
@bazarnov , please, publish your changes
/publish connector=connectors/source-zendesk-chat
|
What
#6287 - Source Zendesk Chat: support oauth
#8819 - Source Zendesk Chat: 'created_at' can be null for old items
How
spec.json
annotation withoauth2.0
source.py
ZendeskChatOauthFlow.java
created_at
forbans
streamOAuth Sreenshots of working flow:
![a1](https://user-images.githubusercontent.com/22987674/147119244-7b0a10d6-8610-4611-8b50-4dd19ac984fa.png)
![a2](https://user-images.githubusercontent.com/22987674/147119270-95e191ad-6d5c-44d7-8bd6-7b7e138b2d33.png)
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here