Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added credentials to ci for new source sentry #7335

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

harshithmullapudi
Copy link
Contributor

@harshithmullapudi harshithmullapudi commented Oct 25, 2021

What

closes #6975

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Oct 25, 2021

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1381447929
❌ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1381447929
🐛 https://gradle.com/s/ic54usqnkfff4

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 25, 2021
@jrhizor jrhizor temporarily deployed to more-secrets October 25, 2021 14:12 Inactive
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets October 25, 2021 14:21 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Oct 25, 2021

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1381517891
❌ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1381517891
🐛 https://gradle.com/s/tk27xgjexsreq

@jrhizor jrhizor temporarily deployed to more-secrets October 25, 2021 14:28 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Oct 25, 2021

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1381599521
❌ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1381599521
🐛 https://gradle.com/s/pxrcetl6xxfj6

@jrhizor jrhizor temporarily deployed to more-secrets October 25, 2021 14:48 Inactive
@harshithmullapudi harshithmullapudi mentioned this pull request Oct 25, 2021
18 tasks
@marcosmarxm
Copy link
Member

marcosmarxm commented Oct 26, 2021

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1383797383
❌ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1383797383
🐛 https://gradle.com/s/zydkk4sgj7rfk

@jrhizor jrhizor temporarily deployed to more-secrets October 26, 2021 02:22 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 1, 2021

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1408410820
❌ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1408410820
🐛 https://gradle.com/s/dp3mzc5rr3uyi

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 1, 2021 14:59 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 1, 2021 15:00 Inactive
@koji-m
Copy link
Contributor

koji-m commented Nov 1, 2021

@harshithmullapudi I can see the error saying that there is not '/test_input/secrets/config.json'. In my local environment, there is my 'secrets/config.json' and pass the test cases.
Was there anything has to do for preparing secrets? (How are secrets given in a CI environment?)

_______ ERROR at setup of TestFullRefresh.test_sequential_reads[inputs0] _______
3119

3120
base_path = PosixPath('/test_input')
3121
connector_config_path = PosixPath('/test_input/secrets/config.json')
3122

3123
    @pytest.fixture(name="connector_config")
3124
    def connector_config_fixture(base_path, connector_config_path) -> SecretDict:
3125
>       with open(str(connector_config_path), "r") as file:
3126
E       FileNotFoundError: [Errno 2] No such file or directory: '/test_input/secrets/config.json'

@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 1, 2021

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1408808338
❌ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1408808338
🐛 https://gradle.com/s/bczqciejftem2

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 1, 2021 16:47 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 1, 2021 16:48 Inactive
@harshithmullapudi
Copy link
Contributor Author

All good waiting for data to be populated in the test account

@koji-m
Copy link
Contributor

koji-m commented Nov 2, 2021

@harshithmullapudi It seems a hostname is not specified in the config.json. (default: sentry.io) As there was not hostname entry in integration_tests/sample_config.json, so I added.

requests.exceptions.ConnectionError: HTTPSConnectionPool(host='none', port=443): Max retries exceeded with url: /api/0/projects/airbyte-09/airbyte-09/events/?full=true (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7efe068f8210>: Failed to establish a new connection: [Errno -3] Try again'))

https://github.com/airbytehq/airbyte/runs/4070427174?check_suite_focus=true#step:8:3244

@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 2, 2021

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1412559500
✅ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1412559500
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       33     22    33%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  891    435    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_sentry/__init__.py       2      0   100%
	 source_sentry/source.py        18      2    89%
	 source_sentry/streams.py       64      4    94%
	 -----------------------------------------------
	 TOTAL                          84      6    93%

@jrhizor jrhizor temporarily deployed to more-secrets November 2, 2021 13:54 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 2, 2021

/publish connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1412636511
✅ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/1412636511

@github-actions github-actions bot removed area/documentation Improvements or additions to documentation area/connectors Connector related issues labels Nov 2, 2021
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 2, 2021 14:15 Inactive
@harshithmullapudi harshithmullapudi merged commit 8ddf686 into master Nov 2, 2021
@harshithmullapudi harshithmullapudi deleted the harshith/test-pr-6975 branch November 2, 2021 14:25
@harshithmullapudi harshithmullapudi changed the title Harshith/test pr 6975 added credentials to ci for new source sentry Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants