-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: Youtube analytics #7407
Conversation
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are nicely done! Please consider to read the comments and make the corrections.
Keep up!
airbyte-config/init/src/main/resources/seed/source_definitions.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-youtube-analytics/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-youtube-analytics/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-youtube-analytics/build.gradle
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-youtube-analytics/integration_tests/abnormal_state.json
Show resolved
Hide resolved
airbyte-integrations/connectors/source-youtube-analytics/integration_tests/sample_config.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-youtube-analytics/integration_tests/sample_state.json
Outdated
Show resolved
Hide resolved
...ectors/source-youtube-analytics/source_youtube_analytics/schemas/channel_annotations_a1.json
Show resolved
Hide resolved
airbyte-integrations/connectors/source-youtube-analytics/source_youtube_analytics/spec.json
Show resolved
Hide resolved
airbyte-integrations/connectors/source-youtube-analytics/unit_tests/test_incremental_streams.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
...ectors/source-youtube-analytics/source_youtube_analytics/schemas/channel_end_screens_a1.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-youtube-analytics/source_youtube_analytics/spec.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-youtube-analytics/source_youtube_analytics/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-youtube-analytics/source_youtube_analytics/source.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-youtube-analytics/source_youtube_analytics/source.py
Show resolved
Hide resolved
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
/test connector=connectors/source-youtube-analytics
|
/test connector=connectors/source-youtube-analytics
|
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain in a docstring the lifecycle of a job and how it relates to streams, as well as the hierarchy of different streams? It's hard to follow how everything works here. Specifically:
- Given that jobs can run for a very long time, is the connector just launching jobs and if there are past ready jobs, it reads the results from those?
- How does the connector "remember" the job IDs of previously launched jobs? or does it not need to because it uses the
list
endpoint? - do we create one job per connector run, and that generates multiple reports?
this is my pieceing together of what's happening based on reading the code. but it would be very valuable to write this all out explicitly to save the reader a lot of time
/test connector=connectors/source-youtube-analytics
|
/test connector=connectors/source-youtube-analytics
|
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
/publish connector=connectors/source-youtube-analytics
|
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
* init source-youtube-analytics Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
What
#2970 - New Source: Youtube Analytics
How
Describe the solution
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here