Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Youtube analytics #7407

Merged
merged 42 commits into from
Nov 19, 2021

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Oct 27, 2021

What

#2970 - New Source: Youtube Analytics

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added the area/connectors Connector related issues label Oct 27, 2021
@CLAassistant
Copy link

CLAassistant commented Oct 27, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are nicely done! Please consider to read the comments and make the corrections.
Keep up!

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets October 28, 2021 08:54 Inactive
@grubberr grubberr linked an issue Oct 28, 2021 that may be closed by this pull request
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets October 29, 2021 10:07 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets October 31, 2021 10:12 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 1, 2021
@grubberr grubberr temporarily deployed to more-secrets November 1, 2021 08:07 Inactive
@grubberr grubberr temporarily deployed to more-secrets November 1, 2021 22:41 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets November 2, 2021 11:20 Inactive
@grubberr grubberr temporarily deployed to more-secrets November 2, 2021 13:47 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Nov 2, 2021

/test connector=connectors/source-youtube-analytics

🕑 connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/1412761849
✅ connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/1412761849
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       33     22    33%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  891    435    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                   Stmts   Miss  Cover
	 ----------------------------------------------------------
	 source_youtube_analytics/__init__.py       2      0   100%
	 source_youtube_analytics/source.py       129     11    91%
	 ----------------------------------------------------------
	 TOTAL                                    131     11    92%

@jrhizor jrhizor temporarily deployed to more-secrets November 2, 2021 14:43 Inactive
@grubberr grubberr temporarily deployed to more-secrets November 17, 2021 09:03 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Nov 17, 2021

/test connector=connectors/source-youtube-analytics

🕑 connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/1470805909
❌ connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/1470805909
🐛 https://gradle.com/s/hsj7xsgd7jtza

@jrhizor jrhizor temporarily deployed to more-secrets November 17, 2021 09:08 Inactive
@grubberr grubberr temporarily deployed to more-secrets November 17, 2021 22:19 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets November 17, 2021 23:07 Inactive
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain in a docstring the lifecycle of a job and how it relates to streams, as well as the hierarchy of different streams? It's hard to follow how everything works here. Specifically:

  1. Given that jobs can run for a very long time, is the connector just launching jobs and if there are past ready jobs, it reads the results from those?
  2. How does the connector "remember" the job IDs of previously launched jobs? or does it not need to because it uses the list endpoint?
  3. do we create one job per connector run, and that generates multiple reports?

this is my pieceing together of what's happening based on reading the code. but it would be very valuable to write this all out explicitly to save the reader a lot of time

@grubberr
Copy link
Contributor Author

grubberr commented Nov 18, 2021

/test connector=connectors/source-youtube-analytics

🕑 connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/1475947720
❌ connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/1475947720
🐛 https://gradle.com/s/2rhwqmwugotpm

@jrhizor jrhizor temporarily deployed to more-secrets November 18, 2021 10:26 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Nov 18, 2021

/test connector=connectors/source-youtube-analytics

🕑 connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/1476779705
✅ connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/1476779705
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                   Stmts   Miss  Cover
	 ----------------------------------------------------------
	 source_youtube_analytics/__init__.py       2      0   100%
	 source_youtube_analytics/source.py       128     12    91%
	 ----------------------------------------------------------
	 TOTAL                                    130     12    91%

@jrhizor jrhizor temporarily deployed to more-secrets November 18, 2021 14:14 Inactive
@grubberr grubberr temporarily deployed to more-secrets November 18, 2021 23:34 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Nov 19, 2021

/publish connector=connectors/source-youtube-analytics

🕑 connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/1480224289
✅ connectors/source-youtube-analytics https://github.com/airbytehq/airbyte/actions/runs/1480224289

@jrhizor jrhizor temporarily deployed to more-secrets November 19, 2021 08:48 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets November 19, 2021 10:16 Inactive
@grubberr grubberr merged commit 530773f into master Nov 19, 2021
@grubberr grubberr deleted the chvaliuk/2970-source-youtube-analytics branch November 19, 2021 10:17
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* init source-youtube-analytics

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Source: Youtube Analytics
7 participants