π Source Mysql - added basic MySql performance tests - #7820
Conversation
Liren Tu (tuliren)
left a comment
There was a problem hiding this comment.
Looks good!
One general suggestion is to use jOOQ code to construct the queries. In that way, many of the string templates can be omitted. But this is not a high priority requirement. Only do it if you think it helps.
* Added new slash command as a prerequisite for #7820
|
/test connector=connectors/source-mysql
|
|
/test-performance connector=connectors/source-mysql
|
Oleksandr Sheheda (alexandr-shegeda)
left a comment
There was a problem hiding this comment.
nice work!
) * Added new slash command as a prerequisite for airbytehq#7820
* [ticket 7489, PR 7820] Source Mysql - added skeleton for MySql performance tests
What
We want to perform more performance tests for connectors.
How
Added skeleton and base tests for the Source MySQL connector.
Since now we would be able to run performance tests locally or by leaving a PR's comment.
Locally: "./gradlew clean :airbyte-integrations:connectors:source-mysql:performanceTest"
In comment: "/test-performance connector=connectors/source-mysql"
As preconditions more scripts were added #7920
Recommended reading order
x.javay.pythonPre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes