Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Mysql - added basic MySql performance tests #7820

Merged

Conversation

etsybaev
Copy link
Contributor

@etsybaev etsybaev commented Nov 10, 2021

What

We want to perform more performance tests for connectors.

How

Added skeleton and base tests for the Source MySQL connector.
Since now we would be able to run performance tests locally or by leaving a PR's comment.
Locally: "./gradlew clean :airbyte-integrations:connectors:source-mysql:performanceTest"
In comment: "/test-performance connector=connectors/source-mysql"

As preconditions more scripts were added #7920

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 10, 2021
@etsybaev etsybaev linked an issue Nov 10, 2021 that may be closed by this pull request
2 tasks
@etsybaev etsybaev temporarily deployed to more-secrets November 10, 2021 15:57 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 10, 2021 18:04 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets November 10, 2021 18:04 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets November 11, 2021 06:53 Inactive
Copy link
Contributor

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

One general suggestion is to use jOOQ code to construct the queries. In that way, many of the string templates can be omitted. But this is not a high priority requirement. Only do it if you think it helps.

@etsybaev etsybaev temporarily deployed to more-secrets November 11, 2021 16:18 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets November 11, 2021 16:23 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets November 11, 2021 17:40 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 11, 2021 18:06 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets November 12, 2021 09:48 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets November 12, 2021 10:55 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 12, 2021 11:42 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 12, 2021 11:42 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets November 12, 2021 12:37 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets November 12, 2021 15:01 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets November 12, 2021 17:48 Inactive
etsybaev added a commit that referenced this pull request Nov 12, 2021
* Added new slash command as a prerequisite for #7820
@etsybaev etsybaev temporarily deployed to more-secrets November 12, 2021 19:18 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 12, 2021 19:28 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 12, 2021 19:45 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets November 14, 2021 11:34 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 14, 2021 12:34 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 14, 2021 12:34 Inactive
@etsybaev etsybaev changed the title [DRAFT_PR_IGNORE_IT] Source Mysql - added skeleton for MySql performance tests 🎉 Source Mysql - added basic MySql performance tests Nov 14, 2021
@etsybaev etsybaev marked this pull request as ready for review November 14, 2021 15:10
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 14, 2021
@etsybaev etsybaev temporarily deployed to more-secrets November 14, 2021 17:13 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets November 14, 2021 17:37 Inactive
@etsybaev
Copy link
Contributor Author

etsybaev commented Nov 14, 2021

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1459444993
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1459444993
No Python unittests run

@etsybaev
Copy link
Contributor Author

etsybaev commented Nov 14, 2021

/test-performance connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1459446148
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1459446148

@jrhizor jrhizor temporarily deployed to more-secrets November 14, 2021 18:09 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 14, 2021 18:09 Inactive
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@etsybaev etsybaev merged commit 3a0eaaf into master Nov 15, 2021
@etsybaev etsybaev deleted the etsybaev/7489-surce-mysql-skeleton-for-performance-tests branch November 15, 2021 10:16
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* [ticket 7489, PR 7820] Source Mysql - added skeleton for MySql performance tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source MySQL: stress test 1000 tables / columns per sync
4 participants